2 Maintenance

Jorge A. Torres edited this page 2021-09-24 11:43:43 -05:00

Table of Contents

• Coding Conventions
• Prioritization
• Compatibility
• Coding Standards
• Code Review
• Discussion tone on issues and PRs

Coding Conventions

Prioritization

• There are three priority labels: low, high, and critical
• The priority severity is based on a combination of how much a merchant would be affected (does it break checkout?) and how many merchants would be affected (all? <10%?)
• Issues that are not enhancements or features should receive a priority label

Compatibility

• Compatibility with WooCommerce core and WordPress core should be maintained and timely

Resources

• https://developer.woocommerce.com/
• https://make.wordpress.org/core/
• https://wordpress.org/news/

Coding Standards

• Follow WooCommerce coding standards
• Use trunk as the base branch for all work going into the next release (Current + 1).
• If there's work going into the release right after the next one (Current + 2), those PRs should use a bleeding or develop branch as base and bleeding or develop should be merged back into trunk right after Current + 1 is released.

Code Review

• Each PR should receive at least one review by a person who is not the author before merge
• Do not squash merge
• Each PR should be thoroughly tested before merge

Discussion tone on issues and PRs

• It is important to maintain a professional and considerate tone when communicating with anyone on the repo.