The more products in the cart, the less user-friendly the header
dropdown becomes. Giving it a `max-height` and making it scroll
resolves this. It also addresses an issue where using the Sticky header
/ Sticky nav option in the Storefront Designer extension would render
the bottom of the dropdown un-viewable when there are many products in
the cart, as it is always off-screen.
ProShop / Galleria have ‘buy now’ buttons so it’s clear they are
commercial products. Deli and Boutique just had ‘install now’ buttons
though so there may have been confusion there.
Previously they displayed inline. This could cause issues with small
sidebars / font size changes - the buttons would stack and look ugly.
Making them `display: block;` provides a more consistent experience.
Previously Header, Footer and Typography settings had random ordering
of controls. Now they all follow the same pattern: Background color >
Heading color > Text color > Link color
Because Storefront changes the ‘Header image’ section title to just
‘Header’ and adds other controls, we need to add a title to the header
image control to create separation between the header settings.
- Removes extra wrapper functions around Core sanitization functions.
- Simplifies the code of the `storefront_sanitize_checkbox()` function.
- Updates the changelog.
- Static strings (as in `echo 'hey';`) or numbers do not need to be
escaped, as there is no possibility to change them without changing the
code.
- When escaping numbers passed to query functions, `absint()` should be
used instead of `intval()`, to make sure to obtain positive integers.
- Strings that are output in HTML should be escaped with `esc_html()`
instead of `esc_attr()`.
- `esc_attr( __() )` can be written as `esc_attr__()`, same for
`esc_html( __() )`.
- Translations should always be escaped.
