mirror of
https://gh.wpcy.net/https://github.com/discourse/discourse.git
synced 2026-05-02 00:05:39 +08:00
### Super high level description: Adds a nested/threaded view for Discourse topics, allowing posts to be displayed as an indented reply tree instead of the default flat chronological stream. Backend: - New /n/:slug/:topic_id routes serving roots, children (paginated), and context (ancestor chain) endpoints - TreeLoader recursively fetches reply trees with configurable max depth, Sort supports top/new/old ordering - NestedViewPostStat caches per-post reply counts (direct + total descendants, whisper-aware) with a backfill job for existing data - NestedTopic model tracks per-topic opt-in and pinned post Frontend: - Recursive <NestedPost> / <NestedPostChildren> components with lazy-load expansion, cloaking, and scroll tracking - NestedViewCache service preserves expansion state and scroll position across back/forward navigation (15 entries, 10min TTL) - Context view for deep-linking to a specific post with its ancestor chain - Floating actions bar, sort selector, real-time MessageBus updates Site settings (hidden): nested_replies_enabled, nested_replies_default, nested_replies_default_sort, nested_replies_max_depth, nested_replies_cap_nesting_depth, nested_replies_toggle_mode_groups, plus a per-category default override. Co-authored-by: Rafael Silva <xfalcox@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Sérgio Saquetim <saquetim@discourse.org>
172 lines
5 KiB
Ruby
172 lines
5 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe "Nested view replying" do
|
|
fab!(:user) { Fabricate(:user, refresh_auto_groups: true) }
|
|
fab!(:topic) { Fabricate(:topic, user: user) }
|
|
fab!(:op) { Fabricate(:post, topic: topic, user: user, post_number: 1) }
|
|
|
|
let(:nested_view) { PageObjects::Pages::NestedView.new }
|
|
let(:composer) { PageObjects::Components::Composer.new }
|
|
|
|
before do
|
|
SiteSetting.nested_replies_enabled = true
|
|
sign_in(user)
|
|
end
|
|
|
|
describe "replying to a nested post" do
|
|
fab!(:root_reply) do
|
|
Fabricate(:post, topic: topic, user: Fabricate(:user), raw: "Root reply to discuss")
|
|
end
|
|
|
|
it "stays on nested view after replying" do
|
|
nested_view.visit_nested(topic)
|
|
expect(nested_view).to have_nested_view
|
|
|
|
nested_view.click_reply_on_post(root_reply)
|
|
expect(composer).to be_opened
|
|
|
|
composer.fill_content("This is my nested reply")
|
|
composer.submit
|
|
|
|
expect(composer).to be_closed
|
|
expect(nested_view).to have_nested_view
|
|
expect(page).to have_current_path(%r{/n/})
|
|
end
|
|
end
|
|
|
|
describe "replying to the OP" do
|
|
it "stays on nested view after replying" do
|
|
nested_view.visit_nested(topic)
|
|
expect(nested_view).to have_nested_view
|
|
|
|
nested_view.click_reply_on_op
|
|
expect(composer).to be_opened
|
|
|
|
composer.fill_content("This is a reply to the original post")
|
|
composer.submit
|
|
|
|
expect(composer).to be_closed
|
|
expect(nested_view).to have_nested_view
|
|
expect(page).to have_current_path(%r{/n/})
|
|
end
|
|
end
|
|
|
|
describe "floating reply button" do
|
|
it "is visible for logged-in users" do
|
|
nested_view.visit_nested(topic)
|
|
expect(nested_view).to have_floating_reply_button
|
|
end
|
|
|
|
it "is not visible for anonymous users" do
|
|
Capybara.reset_sessions!
|
|
nested_view.visit_nested(topic)
|
|
expect(nested_view).to have_no_floating_reply_button
|
|
end
|
|
|
|
it "opens the composer for a top-level reply" do
|
|
nested_view.visit_nested(topic)
|
|
nested_view.click_floating_reply_button
|
|
expect(composer).to be_opened
|
|
|
|
composer.fill_content("A top-level reply via floating button")
|
|
composer.submit
|
|
expect(composer).to be_closed
|
|
|
|
expect(nested_view).to have_nested_view
|
|
expect(page).to have_current_path(%r{/n/})
|
|
end
|
|
|
|
it "hides when the composer is open and reappears when closed" do
|
|
nested_view.visit_nested(topic)
|
|
expect(nested_view).to have_floating_reply_button
|
|
|
|
nested_view.click_floating_reply_button
|
|
expect(composer).to be_opened
|
|
expect(nested_view).to have_no_floating_reply_button
|
|
|
|
composer.close
|
|
expect(composer).to be_closed
|
|
expect(nested_view).to have_floating_reply_button
|
|
end
|
|
end
|
|
|
|
describe "replying to a collapsed post" do
|
|
fab!(:root_reply) do
|
|
Fabricate(:post, topic: topic, user: Fabricate(:user), raw: "Root reply with children")
|
|
end
|
|
|
|
fab!(:child_reply) do
|
|
Fabricate(
|
|
:post,
|
|
topic: topic,
|
|
user: Fabricate(:user),
|
|
raw: "Child reply",
|
|
reply_to_post_number: root_reply.post_number,
|
|
)
|
|
end
|
|
|
|
it "auto-expands a collapsed post after submitting a reply" do
|
|
nested_view.visit_nested(topic)
|
|
expect(nested_view).to have_children_visible_for(root_reply)
|
|
|
|
nested_view.click_reply_on_post(root_reply)
|
|
expect(composer).to be_opened
|
|
|
|
nested_view.click_depth_line(root_reply)
|
|
expect(nested_view).to have_collapsed_bar_for(root_reply)
|
|
|
|
composer.fill_content("Reply to collapsed post")
|
|
composer.submit
|
|
expect(composer).to be_closed
|
|
|
|
expect(nested_view).to have_no_collapsed_bar_for(root_reply)
|
|
expect(nested_view).to have_children_visible_for(root_reply)
|
|
end
|
|
end
|
|
|
|
describe "replying to a post with no existing children" do
|
|
fab!(:root_reply) do
|
|
Fabricate(:post, topic: topic, user: Fabricate(:user), raw: "Post with no children yet")
|
|
end
|
|
|
|
it "shows the depth line on the parent without refresh" do
|
|
nested_view.visit_nested(topic)
|
|
expect(nested_view).to have_no_depth_line_for(root_reply)
|
|
|
|
nested_view.click_reply_on_post(root_reply)
|
|
composer.fill_content("First child reply")
|
|
composer.submit
|
|
expect(composer).to be_closed
|
|
|
|
expect(nested_view).to have_depth_line_for(root_reply)
|
|
end
|
|
end
|
|
|
|
describe "replying to a leaf post" do
|
|
fab!(:root_reply) { Fabricate(:post, topic: topic, user: Fabricate(:user), raw: "Root reply") }
|
|
|
|
fab!(:child_reply) do
|
|
Fabricate(
|
|
:post,
|
|
topic: topic,
|
|
user: Fabricate(:user),
|
|
raw: "Child reply (leaf)",
|
|
reply_to_post_number: root_reply.post_number,
|
|
)
|
|
end
|
|
|
|
it "shows the new reply as a child" do
|
|
nested_view.visit_nested(topic)
|
|
expect(nested_view).to have_post(child_reply)
|
|
|
|
nested_view.click_reply_on_post(child_reply)
|
|
expect(composer).to be_opened
|
|
|
|
composer.fill_content("Reply to leaf post")
|
|
composer.submit
|
|
expect(composer).to be_closed
|
|
|
|
expect(nested_view).to have_children_visible_for(child_reply)
|
|
end
|
|
end
|
|
end
|