mirror of
https://gh.wpcy.net/https://github.com/discourse/discourse.git
synced 2026-05-02 04:42:19 +08:00
8feeaa5d69
### Super high level description: Adds a nested/threaded view for Discourse topics, allowing posts to be displayed as an indented reply tree instead of the default flat chronological stream. Backend: - New /n/:slug/:topic_id routes serving roots, children (paginated), and context (ancestor chain) endpoints - TreeLoader recursively fetches reply trees with configurable max depth, Sort supports top/new/old ordering - NestedViewPostStat caches per-post reply counts (direct + total descendants, whisper-aware) with a backfill job for existing data - NestedTopic model tracks per-topic opt-in and pinned post Frontend: - Recursive <NestedPost> / <NestedPostChildren> components with lazy-load expansion, cloaking, and scroll tracking - NestedViewCache service preserves expansion state and scroll position across back/forward navigation (15 entries, 10min TTL) - Context view for deep-linking to a specific post with its ancestor chain - Floating actions bar, sort selector, real-time MessageBus updates Site settings (hidden): nested_replies_enabled, nested_replies_default, nested_replies_default_sort, nested_replies_max_depth, nested_replies_cap_nesting_depth, nested_replies_toggle_mode_groups, plus a per-category default override. Co-authored-by: Rafael Silva <xfalcox@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Sérgio Saquetim <saquetim@discourse.org>
119 lines
3.2 KiB
Ruby
119 lines
3.2 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe "Nested view pagination" do
|
|
fab!(:user) { Fabricate(:user, refresh_auto_groups: true) }
|
|
fab!(:topic) { Fabricate(:topic, user: user) }
|
|
fab!(:op) { Fabricate(:post, topic: topic, user: user, post_number: 1) }
|
|
|
|
let(:nested_view) { PageObjects::Pages::NestedView.new }
|
|
|
|
before do
|
|
SiteSetting.nested_replies_enabled = true
|
|
sign_in(user)
|
|
end
|
|
|
|
describe "load more children" do
|
|
fab!(:root_reply) do
|
|
Fabricate(:post, topic: topic, user: Fabricate(:user), raw: "Root post with many children")
|
|
end
|
|
|
|
# Create 5 child replies — initial load preloads 3, so "load more" appears
|
|
fab!(:child_1) do
|
|
Fabricate(
|
|
:post,
|
|
topic: topic,
|
|
user: Fabricate(:user),
|
|
raw: "Child reply one",
|
|
reply_to_post_number: root_reply.post_number,
|
|
created_at: 5.minutes.ago,
|
|
)
|
|
end
|
|
|
|
fab!(:child_2) do
|
|
Fabricate(
|
|
:post,
|
|
topic: topic,
|
|
user: Fabricate(:user),
|
|
raw: "Child reply two",
|
|
reply_to_post_number: root_reply.post_number,
|
|
created_at: 4.minutes.ago,
|
|
)
|
|
end
|
|
|
|
fab!(:child_3) do
|
|
Fabricate(
|
|
:post,
|
|
topic: topic,
|
|
user: Fabricate(:user),
|
|
raw: "Child reply three",
|
|
reply_to_post_number: root_reply.post_number,
|
|
created_at: 3.minutes.ago,
|
|
)
|
|
end
|
|
|
|
fab!(:child_4) do
|
|
Fabricate(
|
|
:post,
|
|
topic: topic,
|
|
user: Fabricate(:user),
|
|
raw: "Child reply four",
|
|
reply_to_post_number: root_reply.post_number,
|
|
created_at: 2.minutes.ago,
|
|
)
|
|
end
|
|
|
|
fab!(:child_5) do
|
|
Fabricate(
|
|
:post,
|
|
topic: topic,
|
|
user: Fabricate(:user),
|
|
raw: "Child reply five",
|
|
reply_to_post_number: root_reply.post_number,
|
|
created_at: 1.minute.ago,
|
|
)
|
|
end
|
|
|
|
it "shows load more button and loads additional children on click" do
|
|
nested_view.visit_nested(topic)
|
|
|
|
expect(nested_view).to have_post(root_reply)
|
|
expect(page).to have_css(".nested-post-children__load-more")
|
|
|
|
find(".nested-post-children__load-more").click
|
|
|
|
expect(nested_view).to have_post(child_1)
|
|
expect(nested_view).to have_post(child_2)
|
|
expect(nested_view).to have_post(child_3)
|
|
expect(nested_view).to have_post(child_4)
|
|
expect(nested_view).to have_post(child_5)
|
|
expect(page).to have_no_css(".nested-post-children__load-more")
|
|
end
|
|
end
|
|
|
|
describe "load more roots" do
|
|
# ROOTS_PER_PAGE is 20, so create 22 to have pagination
|
|
before do
|
|
22.times do |i|
|
|
Fabricate(
|
|
:post,
|
|
topic: topic,
|
|
user: Fabricate(:user),
|
|
raw: "Root post number #{i + 1}",
|
|
reply_to_post_number: nil,
|
|
)
|
|
end
|
|
end
|
|
|
|
it "initially shows first page of roots and loads more on scroll" do
|
|
nested_view.visit_nested(topic)
|
|
|
|
expect(nested_view).to have_nested_view
|
|
initial_count = all(".nested-view__roots > .nested-post").count
|
|
expect(initial_count).to eq(20)
|
|
|
|
page.execute_script("window.scrollTo(0, document.body.scrollHeight)")
|
|
|
|
expect(page).to have_css(".nested-view__roots > .nested-post", count: 22, wait: 5)
|
|
end
|
|
end
|
|
end
|
