mirror of
https://gh.wpcy.net/https://github.com/discourse/discourse.git
synced 2026-05-04 08:00:01 +08:00
3521568486
These were previously included in requirejs modules transitively, via
the `discourse-plugins` addon. That was removed in
b27530cdb1.
This commit adds the minimum required modules as vendored shims, and
adds a simple system spec to prevent future regressions of
hbs/this-fallback functionality.
104 lines
3.5 KiB
Ruby
104 lines
3.5 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
describe "JS Deprecation Handling" do
|
|
it "can successfully print a deprecation message after applying production-mode shims" do
|
|
visit("/latest")
|
|
expect(find("#main-outlet-wrapper")).to be_visible
|
|
|
|
# Intercept console.warn so we can enumerate calls later
|
|
page.execute_script <<~JS
|
|
window.intercepted_warnings = [];
|
|
console.warn = (msg) => window.intercepted_warnings.push([msg, (new Error()).stack])
|
|
JS
|
|
|
|
warn_calls = nil
|
|
page.driver.with_playwright_page do |playwright_page|
|
|
warn_calls = playwright_page.evaluate <<~JS
|
|
() => {
|
|
const { deprecate } = require('@ember/debug');
|
|
deprecate("Some message", false, { id: "fake.deprecation", for: "discourse", since: "3.4.0", until: "3.5.0" });
|
|
return window.intercepted_warnings;
|
|
}
|
|
JS
|
|
end
|
|
|
|
expect(warn_calls.size).to eq(1)
|
|
call, backtrace = warn_calls[0]
|
|
|
|
expect(call).to start_with("DEPRECATION: Some message [deprecation id: fake.deprecation]")
|
|
end
|
|
|
|
it "shows warnings to admins for critical deprecations" do
|
|
sign_in Fabricate(:admin)
|
|
|
|
SiteSetting.warn_critical_js_deprecations = true
|
|
SiteSetting.warn_critical_js_deprecations_message =
|
|
"Discourse core changes will be applied to your site on Jan 15."
|
|
|
|
visit("/latest")
|
|
|
|
page.execute_script <<~JS
|
|
const deprecated = require("discourse/lib/deprecated").default;
|
|
deprecated("Fake deprecation message", { id: "fake.deprecation1" })
|
|
deprecated("Other fake deprecation message", { id: "fake.deprecation2" })
|
|
JS
|
|
|
|
message = find("#global-notice-critical-deprecation--fake-deprecation1")
|
|
expect(message).to have_text("One of your themes or plugins contains code which needs updating")
|
|
expect(message).to have_text("fake.deprecation1")
|
|
expect(message).to have_text(SiteSetting.warn_critical_js_deprecations_message)
|
|
|
|
message = find("#global-notice-critical-deprecation--fake-deprecation2")
|
|
expect(message).to have_text("One of your themes or plugins contains code which needs updating")
|
|
expect(message).to have_text("fake.deprecation2")
|
|
expect(message).to have_text(SiteSetting.warn_critical_js_deprecations_message)
|
|
end
|
|
|
|
it "emits ember-this-fallback deprecation for theme .hbs connectors using property fallback" do
|
|
t = Fabricate(:theme, name: "Theme With Hbs Connector")
|
|
t.set_field(
|
|
target: :extra_js,
|
|
name: "discourse/connectors/below-footer/my-connector.hbs",
|
|
value: "{{someProperty}}",
|
|
)
|
|
t.save!
|
|
SiteSetting.default_theme_id = t.id
|
|
|
|
visit "/latest"
|
|
expect(find("#main-outlet-wrapper")).to be_visible
|
|
|
|
try_until_success do
|
|
expect(
|
|
$playwright_logger.logs.any? do |log|
|
|
log[:message].include?("ember-this-fallback.this-property-fallback")
|
|
end,
|
|
).to eq(true)
|
|
end
|
|
end
|
|
|
|
it "can show warnings triggered during initial render" do
|
|
sign_in Fabricate(:admin)
|
|
|
|
t = Fabricate(:theme, name: "Theme With Tests")
|
|
t.set_field(
|
|
target: :extra_js,
|
|
type: :js,
|
|
name: "discourse/connectors/below-footer/my-connector.gjs",
|
|
value: <<~JS,
|
|
import deprecated from "discourse/lib/deprecated";
|
|
function triggerDeprecation(){
|
|
deprecated("Fake deprecation message", { id: "fake.deprecation" })
|
|
}
|
|
export default <template>
|
|
{{triggerDeprecation}}
|
|
</template>
|
|
JS
|
|
)
|
|
t.save!
|
|
SiteSetting.default_theme_id = t.id
|
|
|
|
visit "/latest"
|
|
|
|
expect(page).to have_css("#global-notice-critical-deprecation--fake-deprecation")
|
|
end
|
|
end
|
