mirror of
https://github.com/discourse/discourse.git
synced 2026-08-08 17:53:55 +08:00
4004016329**Previously**, nothing was recorded when an admin completed or dismissed the onboarding panel. Because `enable_site_owner_onboarding` is a hidden setting, `SiteSetting#log` skipped it too, so there was no audit trail for how admins moved through the guide. **In this update**, each step completion, full onboarding completion, and panel dismissal writes a dedicated `UserHistory` staff action. | Before | After | | --- | --- | |  |  |
79 lines
2.3 KiB
Ruby
Vendored
79 lines
2.3 KiB
Ruby
Vendored
# frozen_string_literal: true
|
|
|
|
RSpec.describe Admin::OnboardingEventsController do
|
|
fab!(:admin)
|
|
fab!(:user)
|
|
|
|
describe "#create" do
|
|
context "when signed in as an admin" do
|
|
before { sign_in(admin) }
|
|
|
|
it "logs a staff action for a completed step" do
|
|
post "/admin/onboarding/events.json",
|
|
params: {
|
|
event: "step_completed",
|
|
step: "select_theme",
|
|
}
|
|
|
|
expect(response.status).to eq(204)
|
|
|
|
log = UserHistory.last
|
|
expect(log.action).to eq(UserHistory.actions[:admin_onboarding_step_completed])
|
|
expect(log.acting_user_id).to eq(admin.id)
|
|
expect(log.subject).to eq("select_theme")
|
|
end
|
|
|
|
it "logs a staff action when onboarding is completed" do
|
|
post "/admin/onboarding/events.json", params: { event: "completed" }
|
|
|
|
expect(response.status).to eq(204)
|
|
expect(UserHistory.last.action).to eq(UserHistory.actions[:admin_onboarding_completed])
|
|
end
|
|
|
|
it "logs a staff action when onboarding is dismissed" do
|
|
post "/admin/onboarding/events.json", params: { event: "dismissed" }
|
|
|
|
expect(response.status).to eq(204)
|
|
expect(UserHistory.last.action).to eq(UserHistory.actions[:admin_onboarding_dismissed])
|
|
end
|
|
|
|
it "rejects an unknown event without logging" do
|
|
expect {
|
|
post "/admin/onboarding/events.json", params: { event: "something_else" }
|
|
}.not_to change { UserHistory.count }
|
|
|
|
expect(response.status).to eq(400)
|
|
end
|
|
|
|
it "rejects an unknown step without logging" do
|
|
expect {
|
|
post "/admin/onboarding/events.json",
|
|
params: {
|
|
event: "step_completed",
|
|
step: "not_a_step",
|
|
}
|
|
}.not_to change { UserHistory.count }
|
|
|
|
expect(response.status).to eq(400)
|
|
end
|
|
end
|
|
|
|
it "denies access to a regular user" do
|
|
sign_in(user)
|
|
|
|
expect {
|
|
post "/admin/onboarding/events.json", params: { event: "completed" }
|
|
}.not_to change { UserHistory.count }
|
|
|
|
expect(response.status).to eq(404)
|
|
end
|
|
|
|
it "denies access to an anonymous user" do
|
|
expect {
|
|
post "/admin/onboarding/events.json", params: { event: "completed" }
|
|
}.not_to change { UserHistory.count }
|
|
|
|
expect(response.status).to eq(404)
|
|
end
|
|
end
|
|
end
|
