mirror of
https://github.com/discourse/discourse.git
synced 2026-08-11 02:59:07 +08:00
f9f1540323Previously, the `themes-with-setting` endpoint reported themes with no `ThemeSiteSetting` override as disabled, even though a missing override means the theme inherits the `enable_welcome_banner` default (true), so saving unrelated fields on the admin welcome-banner form silently persisted `false` and hid the banner for those themes. This change falls back to `SiteSetting.defaults[:enable_welcome_banner]` only when no override row exists — while still reporting explicit `false` overrides correctly — matching how `ThemeSiteSetting.generate_theme_map` and `ThemeSiteSettingResolver` resolve effective values. ## Source - Patch Triage: https://patch.discourse.org/patch-triage/1666 Co-authored-by: discourse-patch-triage <272280883+discourse-patch-triage[bot]@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| about_controller_spec.rb | ||
| category_management_controller_spec.rb | ||
| color_palettes_controller_spec.rb | ||
| customize_controller_spec.rb | ||
| design_wizard_controller_spec.rb | ||
| discourse_id_controller_spec.rb | ||
| fonts_controller_spec.rb | ||
| logo_controller_spec.rb | ||
| site_settings_controller_spec.rb | ||
| upcoming_changes_controller_spec.rb | ||
| welcome_banner_controller_spec.rb | ||
