Discourse/discourse
Discourse/discourse
0
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-08-07 13:19:19 +08:00
Code Packages Activity Actions
discourse/plugins/discourse-adplugin/spec/system/page_objects
History
Exact
Rafael dos Santos Silva 23a5a3182d
 FIX: Honor house_ads_after_nth_root in the nested replies view (#40742) 
Previously, the `nested-roots-between` ad connector rendered an empty
`.ad-connector` div after every root reply, and a house ad always
appeared after the first root regardless of `house_ads_after_nth_root`,
because the slot-selection logic treats index 0 as a non-between
placement and the OR'd placement guards in `house-ad` defeated the
nth-root check added in #40198.

This change gates the connector with `shouldRender` (mirroring the
`after-topic-list-item` connector) and replaces the OR'd guards with a
single placement-aware check, so house ads only render after every nth
root reply.

Follow-up to #40198.
2026-06-10 12:45:22 -03:00
..
components FIX: Honor house_ads_after_nth_root in the nested replies view (#40742) 2026-06-10 12:45:22 -03:00
pages