mirror of
https://github.com/discourse/discourse.git
synced 2026-08-06 13:08:40 +08:00
c44ed224e6Previously, admin plugin pages carried multiple navs that repeated links the surrounding page already offered: - the plugins index listed a tab for some plugins, directly above the table that links to those same config pages - a plugin whose only tab is "Settings" still rendered a one item tab bar This change drops those and gives the older plugin pages the breadcrumb trail the show route already has, ending on the plugin being configured rather than on "Installed plugins". - Also removes a duplicate wrapper on the plugin settings route, which repeated `.content-body` - The breadcrumb fallback in admin-plugins.gjs now only applies to third-party plugins on the legacy admin route Before (why a tab for only one link?): <img width="600" alt="image" src="https://github.com/user-attachments/assets/a37a5986-66c0-4cbe-861c-aa453ec8f10a" /> After (no tab for single links): <img width="450" alt="image" src="https://github.com/user-attachments/assets/3a0c80ee-0459-4df5-81e7-774abe8946d1" /> Before (why tabs for redundant plugin links): <img width="2240" height="832" alt="image" src="https://github.com/user-attachments/assets/4f4254d8-6a73-4031-9911-f725ff5ae37f" /> After (no tabs): <img width="2236" height="728" alt="image" src="https://github.com/user-attachments/assets/24d54ec8-8973-4e39-9844-092d384b61d8" /> Before (wrong breadcrumb): <img width="350" alt="image" src="https://github.com/user-attachments/assets/89a43a36-f97b-4a45-b537-670b26de4bc3" /> After (correct breadcrumb pattern): <img width="350" alt="image" src="https://github.com/user-attachments/assets/706f75b1-1245-427d-8913-193dce99703d" /> |
||
|---|---|---|
| .. | ||
| page_objects | ||
| ad_impression_spec.rb | ||
| admin_house_ad_spec.rb | ||
| core_features_spec.rb | ||
| dfp_ads_spec.rb | ||
| house_ads_nested_view_spec.rb | ||
