mirror of
https://gh.wpcy.net/https://github.com/discourse/discourse.git
synced 2026-05-11 11:25:16 +08:00
ad21ae98ff
## 🔍 Overview This PR adds bulk selection functionality to the PostList component and implements optimized bulk deletion for the drafts page. Users can now select multiple drafts and delete them all at once with a single network request, significantly improving performance and user experience. The implementation includes: - A new reusable bulk selection system for PostList components - Optimized bulk delete endpoint that reduces network requests by 90% - Comprehensive bulk controls UI with select all/clear all functionality - Shift+click range selection similar to topic lists - Complete test coverage for all new functionality ## ➕ More details **Bulk Selection System** The PostList component now supports optional bulk selection through these new parameters: - `@bulkSelectEnabled={{true}}` - Shows checkboxes next to each post - `@bulkSelectHelper={{helper}}` - Manages selection state (use `PostBulkSelectHelper`) - `@bulkActions={{actions}}` - Array of bulk action objects for the dropdown menu **Usage Example:** ```gjs import Component from "@glimmer/component"; import { action } from "@ember/object"; import didUpdate from "@ember/render-modifiers/modifiers/did-update"; import PostBulkSelectHelper from "discourse/lib/post-bulk-select-helper"; export default class MyComponent extends Component { bulkSelectHelper = new PostBulkSelectHelper(this); constructor() { super(...arguments); // Initial updatePosts call this.updateBulkSelectPosts(); } @action updateBulkSelectPosts() { if (this.shouldEnableBulkSelect && this.args.posts) { this.bulkSelectHelper.updatePosts(this.args.posts); } } get showBulkSelectHelper() { return this.shouldEnableBulkSelect ? this.bulkSelectHelper : null; } get bulkActions() { return [ { label: "delete_selected", icon: "trash-can", action: this.handleBulkDelete, class: "btn-danger" } ]; } <template> <PostList @posts={{@posts}} @bulkSelectEnabled={{this.shouldEnableBulkSelect}} @bulkSelectHelper={{this.showBulkSelectHelper}} @bulkActions={{this.bulkActions}} {{didUpdate this.updateBulkSelectPosts @posts}} /> </template> } ``` **Performance Optimization** The drafts page now uses a new bulk delete endpoint (`DELETE /drafts/bulk_destroy`) that: - Processes multiple drafts in a single HTTP request instead of N individual requests - Uses database transactions for atomic operations (all-or-nothing) - Reduces database queries from 2N to 2 total queries - Validates draft sequences upfront to fail fast on conflicts **Technical Implementation** - `PostBulkSelectHelper`: New helper class for managing selection state with support for individual selection, range selection (shift+click), and bulk operations with reactive posts tracking - `PostListBulkControls`: New component providing selection count, select all/clear all buttons, and bulk actions dropdown - Enhanced PostList and PostListItem components with conditional bulk selection UI - Updated user-stream component to use optimized bulk deletion with automatic selection cleanup - Comprehensive styling with responsive design **API Changes** - New controller action: `DraftsController#bulk_destroy` - New route: `DELETE /drafts/bulk_destroy` - New JavaScript method: `Draft.bulkClear(drafts)` - Enhanced `PostBulkSelectHelper` with `updatePosts()` method for reactive data updates - Fully backward compatible - existing single delete functionality unchanged **Testing** - 9 new controller specs covering bulk deletion edge cases, validation, and API access - 11 integration tests for PostList bulk selection functionality - 10 system specs for end-to-end drafts page bulk selection workflows - All existing tests continue to pass ## 📹 Screen Recording https://github.com/user-attachments/assets/2d5a9b38-f1cb-43ee-88ac-285b71083612 |
||
|---|---|---|
| .. | ||
| admin | ||
| api | ||
| examples | ||
| about_controller_spec.rb | ||
| application_controller_spec.rb | ||
| associate_accounts_controller_spec.rb | ||
| badges_controller_spec.rb | ||
| bookmarks_controller_spec.rb | ||
| categories_controller_spec.rb | ||
| clicks_controller_spec.rb | ||
| composer_controller_spec.rb | ||
| composer_messages_controller_spec.rb | ||
| crawler_hreflang_spec.rb | ||
| csp_reports_controller_spec.rb | ||
| default_headers_spec.rb | ||
| directory_columns_controller_spec.rb | ||
| directory_items_controller_spec.rb | ||
| discourse_id_controller_spec.rb | ||
| do_not_disturb_controller_spec.rb | ||
| drafts_controller_spec.rb | ||
| edit_directory_columns_controller_spec.rb | ||
| email_controller_spec.rb | ||
| embed_controller_spec.rb | ||
| emojis_controller_spec.rb | ||
| exceptions_controller_spec.rb | ||
| export_csv_controller_spec.rb | ||
| extra_locales_controller_spec.rb | ||
| finish_installation_controller_spec.rb | ||
| form_templates_controller_spec.rb | ||
| forums_controller_spec.rb | ||
| groups_controller_spec.rb | ||
| hashtags_controller_spec.rb | ||
| highlightjs_controller_spec.rb | ||
| home_page_controller_spec.rb | ||
| inline_onebox_controller_spec.rb | ||
| invites_controller_spec.rb | ||
| list_controller_spec.rb | ||
| metadata_controller_spec.rb | ||
| net_http_header_spec.rb | ||
| net_http_timeout_spec.rb | ||
| noscript_escape_spec.rb | ||
| notifications_controller_spec.rb | ||
| offline_controller_spec.rb | ||
| omniauth_callbacks_controller_spec.rb | ||
| onebox_controller_spec.rb | ||
| permalinks_controller_spec.rb | ||
| post_action_users_controller_spec.rb | ||
| post_actions_controller_spec.rb | ||
| post_localizations_controller_spec.rb | ||
| post_readers_controller_spec.rb | ||
| posts_controller_spec.rb | ||
| presence_controller_spec.rb | ||
| published_pages_controller_spec.rb | ||
| push_notification_controller_spec.rb | ||
| qunit_controller_spec.rb | ||
| reviewable_claimed_topics_controller_spec.rb | ||
| reviewable_notes_controller_spec.rb | ||
| reviewables_controller_spec.rb | ||
| robots_txt_controller_spec.rb | ||
| safe_mode_controller_spec.rb | ||
| search_controller_spec.rb | ||
| session_controller_spec.rb | ||
| sidebar_sections_controller_spec.rb | ||
| similar_topics_controller_spec.rb | ||
| site_controller_spec.rb | ||
| sitemap_controller_spec.rb | ||
| slugs_controller_spec.rb | ||
| static_controller_spec.rb | ||
| steps_controller_spec.rb | ||
| stylesheets_controller_spec.rb | ||
| svg_sprite_controller_spec.rb | ||
| tag_groups_controller_spec.rb | ||
| tags_controller_spec.rb | ||
| theme_javascripts_controller_spec.rb | ||
| topic_localizations_controller_spec.rb | ||
| topic_view_stats_controller_spec.rb | ||
| topics_controller_spec.rb | ||
| uploads_controller_multisite_spec.rb | ||
| uploads_controller_spec.rb | ||
| user_actions_controller_spec.rb | ||
| user_api_key_clients_controller_spec.rb | ||
| user_api_keys_controller_spec.rb | ||
| user_avatars_controller_spec.rb | ||
| user_badges_controller_spec.rb | ||
| user_status_controller_spec.rb | ||
| users_controller_spec.rb | ||
| users_email_controller_spec.rb | ||
| webhooks_controller_spec.rb | ||
| wizard_controller_spec.rb | ||
