discourse/spec
Martin Brennan ac1d0e38ce
DEV: Properly clean up global setting overrides in specs (#35058)
In the `SiteSettingExtension`, when calling
`SiteSetting.send(:setting_name, value)`,
if the setting counts as a global one, we add it to the list of hidden
and shadowed site settings in memory. However, when using the
`global_setting` helper in specs, we were not cleaning up these
overrides after the spec finished, leading to potential flakiness
in tests that rely on the visibility of site settings.

The fix is to just remove the setting from the hidden and shadowed
list after the spec is done.
2025-09-30 17:44:41 +10:00
..
db/migrate DEV: Fix incorrect SyncTimerableIdTopicId migration (#34837) 2025-09-17 13:54:29 +08:00
fabricators DEV: Add missing e2e tests for viewing admin email logs (#35033) 2025-09-30 09:02:30 +08:00
fixtures SECURITY: Use nonce-based restrictions during restore 2025-09-30 10:09:46 +08:00
generator DEV: Silence the output of migration specs (#26365) 2024-03-26 11:32:44 +01:00
helpers DEV: Remove dual mode support for palettes and drop theme-owned palettes (#34467) 2025-08-26 06:24:11 +03:00
import_export DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577) 2025-07-11 11:16:34 -03:00
initializers DEV: Patch ActiveRecord's postgresql adapter .new_client (#33820) 2025-09-18 11:34:37 +08:00
integration DEV: Debug cookie overflows 2025-09-01 09:38:52 +02:00
integrity Build(deps): Bump propshaft from 1.2.1 to 1.3.1 (#34967) 2025-09-28 15:13:35 +02:00
jobs DEV: rename topic_id to timerable_id for BaseTimer (#34667) 2025-09-17 13:19:17 +08:00
lib SECURITY: Use nonce-based restrictions during restore 2025-09-30 10:09:46 +08:00
mailers DEV: Remove ability to use users' names in group mention notifications and mentions shown in emails and added :user_notification_email_options plugin modifier to allow plugins reintroduce this or other modifications to emails (#33449) 2025-07-14 15:20:08 -05:00
models DEV: Touch-ups and test coverage for Reviewable#perform (#34950) 2025-09-25 15:17:24 +08:00
multisite FEATURE: Themeable site settings (#32233) 2025-07-16 11:00:21 +10:00
queries/reports UX: Add admin report for associated accounts by login provider (#34187) 2025-08-14 09:24:14 -04:00
requests FEATURE: Bulk select posts and delete drafts (#34972) 2025-09-29 12:47:54 -07:00
script/import_scripts DEV: Catch missing translations during test runs (#26258) 2024-05-24 22:15:53 +08:00
serializers DEV: Add capability to pass an icon setting into auth provider registration (#34584) 2025-08-28 09:14:36 -05:00
services FIX: add support for subfolder in discourse-id registration (#35011) 2025-09-29 20:06:57 +02:00
support SECURITY: Rich editor chat transcript XSS 2025-09-30 10:09:43 +08:00
system DEV: Add missing e2e tests for viewing admin email logs (#35033) 2025-09-30 09:02:30 +08:00
tasks DEV: Change pre-release suffix from -dev to -latest (#35007) 2025-09-29 13:10:03 +01:00
views FIX: Use correct subcategory subfolder path in crawler (#34250) 2025-08-12 16:14:50 +08:00
rails_helper.rb DEV: Properly clean up global setting overrides in specs (#35058) 2025-09-30 17:44:41 +10:00
regenerate_swagger_docs
swagger_helper.rb DEV: Bump rswag-specs from 2.11.0 to 2.13.0 (#24654) 2023-12-07 08:16:47 +08:00