mirror of
https://github.com/discourse/discourse.git
synced 2026-03-04 01:15:08 +08:00
a2b22d182e
DEV: email/receiver tests should explicitly test alternative_reply_by_email_addresses
Some of the email/receiver tests were using an alternative reply address in
their data, implicitly testing that functionality.
This commit modifies the test email fixtures to always use the main reply
address, and added a separate test explicitly testing the functionality of
`alternative_reply_by_email_addresses`.
This serves the mission of configuring as little as possible to not rely on
side effects.
DEV: email/processor tests should explicitly configure reply-by-email
Tests that rely on reply-by-email being configured should explicitly do so.
They're now moved to a common context in the same style as email/receiver
specs.
FIX: email to a category should not require enable reply-by-email
This commit removes the side effect of disabling category email address lookups
when `reply_by_email_enabled` is not configured, restoring functionality to the
situation where a category's `email_in` is configured without
`reply_by_email_enabled`.
Added tests for each of these situations.
DEV: separate tests for email receiver by whether reply_by_email should be configured
The impetus for this change is commit e05ef50c introducing an unintended side
effect that *should* have caused tests to fail; specifically the situation
where `email_in` is enabled and a category has an incoming email address
configured, but `reply_by_email_enabled` is *not* enabled.
The change in the referenced commit broke this configuration, but this was not
noticed as the spec always configured `reply_by_email_enabled`.
The only change made in this commit is reorganising the tests such that
reply-by-email is only configured when necessary. Thus, this commit *alone*
will break tests.
17 lines
457 B
Text
17 lines
457 B
Text
Return-Path: <discourse@bar.com>
|
|
From: Foo Bar <discourse@bar.com>
|
|
To: reply+4f97315cc828096c9cb34c6f1a0d6fe8@bar.com
|
|
Date: Fri, 15 Jan 2016 00:12:43 +0100
|
|
Message-ID: <180@foo.bar.mail>
|
|
Mime-Version: 1.0
|
|
Content-Type: text/html; charset=UTF-8
|
|
Content-Transfer-Encoding: quoted-printable
|
|
|
|
<div>
|
|
<div dir="auto">
|
|
<p>This is a <b>GMAIL</b> reply ;)</p>
|
|
</div>
|
|
<div class="gmail_signature">
|
|
<p>This is the <i>elided</i> part!</p>
|
|
</div>
|
|
</div>
|
