mirror of
https://github.com/discourse/discourse.git
synced 2026-03-03 23:54:20 +08:00
DEV: email/receiver tests should explicitly test alternative_reply_by_email_addresses
Some of the email/receiver tests were using an alternative reply address in
their data, implicitly testing that functionality.
This commit modifies the test email fixtures to always use the main reply
address, and added a separate test explicitly testing the functionality of
`alternative_reply_by_email_addresses`.
This serves the mission of configuring as little as possible to not rely on
side effects.
DEV: email/processor tests should explicitly configure reply-by-email
Tests that rely on reply-by-email being configured should explicitly do so.
They're now moved to a common context in the same style as email/receiver
specs.
FIX: email to a category should not require enable reply-by-email
This commit removes the side effect of disabling category email address lookups
when `reply_by_email_enabled` is not configured, restoring functionality to the
situation where a category's `email_in` is configured without
`reply_by_email_enabled`.
Added tests for each of these situations.
DEV: separate tests for email receiver by whether reply_by_email should be configured
The impetus for this change is commit
|
||
|---|---|---|
| .. | ||
| apple_mail_attachment.eml | ||
| attached_eml_file.eml | ||
| attached_pdf_file.eml | ||
| attached_rb_file.eml | ||
| attached_txt_file.eml | ||
| attached_txt_file_2.eml | ||
| auto_generated_allowlisted.eml | ||
| auto_generated_header.eml | ||
| auto_generated_precedence.eml | ||
| auto_generated_unblocked.eml | ||
| bad_destinations.eml | ||
| base64_encoded_body.eml | ||
| blocklist_allowlist_email.eml | ||
| body_with_image.eml | ||
| bounced_email.eml | ||
| bounced_email_multiple_status_codes.eml | ||
| cc.eml | ||
| chinese_reply.eml | ||
| dmarc_fail.eml | ||
| email_reply_1.eml | ||
| email_reply_2.eml | ||
| email_reply_3.eml | ||
| email_reply_4.eml | ||
| email_reply_like.eml | ||
| email_reply_staged.eml | ||
| email_reply_to_group_email_username.eml | ||
| email_to_group_email_username_1.eml | ||
| email_to_group_email_username_2.eml | ||
| email_to_group_email_username_2_as_unknown_sender.eml | ||
| email_to_group_email_username_3.eml | ||
| email_to_group_email_username_auto_generated.eml | ||
| encoded_display_name.eml | ||
| encoded_filename.eml | ||
| encoding_undefined_conversion.eml | ||
| exchange_html_body.eml | ||
| exchange_html_body_and_reply.eml | ||
| exchange_html_reply.eml | ||
| existing_user.eml | ||
| forwarded_by_group_to_inbox.eml | ||
| forwarded_by_group_to_inbox_double_cc.eml | ||
| forwarded_email_1.eml | ||
| forwarded_email_2.eml | ||
| forwarded_email_3.eml | ||
| forwarded_email_4.eml | ||
| forwarded_email_to_category.eml | ||
| from_reply_by_email_address.eml | ||
| from_the_future.eml | ||
| gmail_html_reply.eml | ||
| group_existing_user.eml | ||
| hard_bounce_via_verp.eml | ||
| hard_bounce_via_verp_2.eml | ||
| hebrew_reply.eml | ||
| html_reply.eml | ||
| ignored.eml | ||
| inactive_sender.eml | ||
| inline_image.eml | ||
| inline_image_2.eml | ||
| inline_mixed_replies.eml | ||
| inline_reply.eml | ||
| invalid_from_1.eml | ||
| invalid_from_2.eml | ||
| iphone_signature.eml | ||
| like.eml | ||
| logo_1.eml | ||
| logo_2.eml | ||
| long_embedded_email_headers.eml | ||
| mailinglist.eml | ||
| mailinglist_dmarc_fail.eml | ||
| mailinglist_reply.eml | ||
| mailinglist_short_message.eml | ||
| mailinglist_unsubscribe.eml | ||
| mailman_1.eml | ||
| mailman_2.eml | ||
| mailman_3.eml | ||
| mailman_4.eml | ||
| missing_message_id.eml | ||
| mute.eml | ||
| new_user.eml | ||
| no_body.eml | ||
| no_body_with_image.eml | ||
| no_date.eml | ||
| no_from.eml | ||
| no_subject.eml | ||
| null_byte_in_subject.eml | ||
| old_destination.eml | ||
| on_date_contact_wrote.eml | ||
| original_message.eml | ||
| paragraphs.eml | ||
| previous_replies.eml | ||
| previous_replies_de.eml | ||
| quirks_exchange_xars.eml | ||
| readonly.eml | ||
| removed_attachments.eml | ||
| reply_above.eml | ||
| reply_above_de.eml | ||
| reply_and_forwarded.eml | ||
| reply_to_category_address.eml | ||
| reply_to_different_to_from.eml | ||
| reply_to_different_to_from_no_x_original.eml | ||
| reply_to_different_to_from_quoted_display_name.eml | ||
| reply_to_different_to_from_x_original_different.eml | ||
| reply_to_whitespaces.eml | ||
| reply_user_matching.eml | ||
| reply_user_matching_alternativereplyaddr.eml | ||
| reply_user_not_matching.eml | ||
| reply_user_not_matching_but_known.eml | ||
| reply_with_8bit_encoding.eml | ||
| reply_with_weird_encoding.eml | ||
| screened_email.eml | ||
| silenced_sender.eml | ||
| soft_bounce_via_verp.eml | ||
| spam_x_ses_spam_verdict.eml | ||
| spam_x_spam_flag.eml | ||
| spam_x_spam_status.eml | ||
| staged_reply_restricted.eml | ||
| staged_sender.eml | ||
| text_and_html_reply.eml | ||
| text_reply.eml | ||
| tl3_user.eml | ||
| tl4_user.eml | ||
| too_many_mentions.eml | ||
| too_small.eml | ||
| track.eml | ||
| unparsable_email_addresses.eml | ||
| unsorted_parts.eml | ||
| unsubscribe_body.eml | ||
| unsubscribe_new_user.eml | ||
| unsubscribe_subject.eml | ||
| user_not_found.eml | ||
| verp_bounce_different_final_recipient.eml | ||
| watch.eml | ||