0
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-08-09 21:45:25 +08:00
discourse/spec/system/page_objects/components
Keegan George 9866827083
DEV: Code review and fixes
- Don't fire the onboarding step's completion callback against a destroyed
  component. Previewing a homepage routes away from the banner, so the step
  hands its callback back on teardown and the service falls back to writing
  the store key and audit event itself.
- Make the collapsed banner's "x of 3 steps completed" count reactive. It was
  reading the key value store, which doesn't trigger a re-render.
- Stop memoizing a font stack probed before the stylesheet that defines the
  font classes has loaded, which pinned the wrong font for the page's lifetime.
- Add the missing `start_posting.completed` label, which rendered as a raw
  i18n key once the step was done, plus an integrity spec so a step can't ship
  without both labels. Sentence case for the other two step titles.
- Collapse the eight site setting steps in DesignWizard::Apply into one that
  iterates the hash the contract already builds.
- Move the wizard's stylesheet link handling into color-scheme-manager so all
  the light/dark link knowledge lives in one place.
- Give the step dots their own class instead of borrowing the image carousel's,
  and put the panel on its own z-layer below modals so dialogs behind it stay
  reachable.
- Dock the panel to the bottom edge on narrow viewports. A full height side
  rail covered the page it's meant to be previewing.
- Pull the hardcoded base-light values in design-wizard.scss into named
  variables so each one is declared once.
- Drop the dead --design-wizard-chrome-font-size plumbing.
- Note why update_palette_selectability resets everything and why update_all
  is safe there.
- Tests: specs for PalettePairs and ResolvePalette, the user selectable palette
  toggle in both directions, a failed progress save, and the case where there
  are no palettes to offer. Fixed a viewport assertion that couldn't fail and
  a link cleanup that leaked between tests.
2026-08-06 11:41:03 -07:00
..
dev_tools DEV: Add an upcoming change toggler in the dev tools sidebar (#39027) 2026-04-02 07:50:27 +10:00
navigation_menu A11Y: don't use the title attribute for category and tag descriptions (#42005) 2026-07-24 09:49:41 -04:00
review FIX: Use replacement icon class for all dot-namespaced icon IDs (#38713) 2026-03-20 09:50:15 +01:00
about_page_site_activity.rb
about_page_site_activity_item.rb
about_page_users_list.rb
ace_editor.rb
admin_about_config_area_contact_information_card.rb FEATURE: Localizable /about page fields via its settings page (#41123) 2026-06-26 20:41:08 +08:00
admin_about_config_area_general_settings_card.rb FEATURE: Localizable /about page fields via its settings page (#41123) 2026-06-26 20:41:08 +08:00
admin_about_config_area_group_listing_card.rb
admin_about_config_area_your_organization_card.rb UX: Organization website field (#40418) 2026-06-04 09:32:19 -07:00
admin_changes_banner.rb
admin_customize_theme_install_button.rb
admin_dashboard_date_range_picker.rb UX: Anchor dashboard date range picker on the start month (#40395) 2026-06-02 07:18:33 +08:00
admin_dashboard_engagement.rb PERF: limit categories rendered in dashboard category pickers (#42078) 2026-07-29 07:12:06 +03:00
admin_dashboard_search.rb FIX: Exclude anonymous searches from the dashboard search section (#40966) 2026-06-17 14:32:04 +08:00
admin_dashboard_site_traffic.rb FEATURE: Show bounce rate and average session duration on the dashboard (#40936) 2026-07-03 10:49:32 +08:00
admin_fonts_form.rb
admin_logo_form.rb
admin_onboarding_banner.rb More fixes 2026-08-05 15:24:39 -05:00
admin_theme_settings_editor.rb
admin_theme_translations_settings_editor.rb
base.rb
blocks.rb DEV: Add Block API for declarative, validated UI extension points (#36810) 2026-02-25 17:36:43 -03:00
bookmark_list.rb FIX: Serialize only a bookmark target's active assignment (#41397) 2026-07-06 06:34:22 +08:00
bookmark_menu.rb FEATURE: Change default upcoming change promotion status to Beta (#41275) 2026-07-06 09:13:37 +10:00
calendar_date_time_picker.rb
category_badge.rb
category_list.rb
category_permission_row.rb
category_type_card.rb FEATURE: Add outlets for CategoryTypeCard components (#38268) 2026-03-09 11:40:17 +10:00
color_palette_editor.rb
composer.rb UX: Composer redesign (#41781) 2026-07-20 17:56:48 +10:00
composer_image_grid.rb
composer_onebox_toolbar.rb FEATURE: Add onebox toolbar and show preview for rich editor (#39054) 2026-04-14 11:05:11 -03:00
d_editor_original_translation_preview.rb FEATURE: Allow editing translated image captions (#41915) 2026-07-22 22:40:19 +08:00
d_filter_controls.rb UX: improve admin filters, add to users and permalinks (#42029) 2026-07-24 17:04:26 -04:00
d_icon_grid_picker.rb FIX: Allow typing inside float-kit menus rendered from within a modal (#39370) 2026-04-21 15:08:50 +02:00
d_menu.rb UX: Add or remove category types with a dropdown (#39477) 2026-04-30 11:38:50 +10:00
d_page_header.rb
d_select.rb
d_toggle_switch.rb
design_wizard_panel.rb DEV: Code review and fixes 2026-08-06 11:41:03 -07:00
dialog.rb FEATURE: Make can_permanently_delete visible with strong safeguards (#39179) 2026-04-16 09:01:35 +02:00
drafts_menu.rb
emoji_picker.rb DEV: Restore and fix emoji_deny_list spec (#39505) 2026-04-24 15:11:56 +02:00
empty_state.rb
fast_editor.rb
filter.rb
form_kit.rb FEATURE: simplifed event creation in the composer (#39835) 2026-05-26 15:04:05 -04:00
group-card.rb
group_selector.rb
home_logo.rb
image_grid_carousel.rb
interface_color_mode.rb
interface_color_selector.rb
language_switcher.rb FIX: User options take precedence over show-original anon cookie (#39520) 2026-04-25 00:44:20 +08:00
logo.rb
manage_reports_modal.rb FIX: Disable the last down-arrow in manage reports modal on mobile (#40540) 2026-06-04 15:38:21 +03:00
nested_activity_log.rb FIX: Add small action controls to nested activity log (#42108) 2026-07-29 10:19:47 -05:00
new_topic_list_toggle.rb
new_topic_list_toggle_tab.rb
notifications_tracking.rb
photoswipe.rb
pikaday_calendar.rb DEV: Fix a flake in pikaday spec (#39719) 2026-05-05 12:22:01 +02:00
post.rb DEV: Remove per topic toggle (#40869) 2026-06-15 18:43:36 +08:00
private_message_map.rb
review_note_form.rb
select_kit.rb UX: Keep usable tags before disabled rows when sorted alphabetically (#39356) 2026-05-26 09:29:11 +02:00
sidebar_header_dropdown.rb UX: Drop legacy mobile-mode site settings (#40226) 2026-05-26 09:23:13 +01:00
theme_translation_text_area.rb
toasts.rb
tooltips.rb
topic_admin_menu.rb
topic_list.rb Revert "FEATURE: discourse-workflows (#39704)" (#40366) 2026-05-28 13:59:42 +01:00
topic_list_controls.rb DEV: Bump unified new upcoming change to Beta (#41454) 2026-07-08 09:50:19 +10:00
topic_list_header.rb FIX: Beacon pageview tracker drops query-param-only route transitions (#39780) 2026-05-08 16:15:23 +08:00
topic_map.rb
topic_query_filter.rb
topic_reply_choice_dialog.rb
topic_view.rb
translation_composer.rb
uppy_image_uploader.rb
user_card.rb FIX: prevent silence_reason from leaking private email body (#39337) 2026-04-17 17:45:09 +03:00
user_menu.rb FIX: Notifications for upcoming changes not updating filter (#39680) 2026-05-05 17:28:46 +10:00
welcome_banner.rb FIX: Hand off search cleanly between welcome banner and header search (#42018) 2026-07-28 15:56:20 +02:00