0
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-08-07 13:19:19 +08:00
discourse/spec/system/page_objects
Keegan George 9866827083
DEV: Code review and fixes
- Don't fire the onboarding step's completion callback against a destroyed
  component. Previewing a homepage routes away from the banner, so the step
  hands its callback back on teardown and the service falls back to writing
  the store key and audit event itself.
- Make the collapsed banner's "x of 3 steps completed" count reactive. It was
  reading the key value store, which doesn't trigger a re-render.
- Stop memoizing a font stack probed before the stylesheet that defines the
  font classes has loaded, which pinned the wrong font for the page's lifetime.
- Add the missing `start_posting.completed` label, which rendered as a raw
  i18n key once the step was done, plus an integrity spec so a step can't ship
  without both labels. Sentence case for the other two step titles.
- Collapse the eight site setting steps in DesignWizard::Apply into one that
  iterates the hash the contract already builds.
- Move the wizard's stylesheet link handling into color-scheme-manager so all
  the light/dark link knowledge lives in one place.
- Give the step dots their own class instead of borrowing the image carousel's,
  and put the panel on its own z-layer below modals so dialogs behind it stay
  reachable.
- Dock the panel to the bottom edge on narrow viewports. A full height side
  rail covered the page it's meant to be previewing.
- Pull the hardcoded base-light values in design-wizard.scss into named
  variables so each one is declared once.
- Drop the dead --design-wizard-chrome-font-size plumbing.
- Note why update_palette_selectability resets everything and why update_all
  is safe there.
- Tests: specs for PalettePairs and ResolvePalette, the user selectable palette
  toggle in both directions, a failed progress save, and the case where there
  are no palettes to offer. Fixed a viewport assertion that couldn't fail and
  a link cleanup that leaked between tests.
2026-08-06 11:41:03 -07:00
..
components DEV: Code review and fixes 2026-08-06 11:41:03 -07:00
modals DEV: Adjustments 2026-08-04 10:49:24 -05:00
pages FIX: Ensure the language dropdowns from the frontend does not add interface language to understood languages (#42301) 2026-08-04 18:21:49 +08:00
cdp.rb DEV: Make nested scroll restoration spec deterministic (#42096) 2026-07-28 11:50:33 -05:00