Followup 5823e4e3b2,
this commit allows the addition of users along with
groups to access control lists, modifying DAccessControl
to support selecting a user or group from the same
search input.
Shown here is a mix of user & group permissions in the
`DAccessControl` component:
<img width="611" height="664" alt="image"
src="https://github.com/user-attachments/assets/c25e13b0-8885-4ce7-972c-5116f3acb094"
/>
When the search opens, we show the site's groups that
the user can see as preloaded values, showing only the
group name for clarity:
<img width="612" height="389" alt="image"
src="https://github.com/user-attachments/assets/df93a94b-918e-4fed-b045-ac72f02aca41"
/>
When searching a GET request is sent and users are included
in search results.
<img width="608" height="404" alt="image"
src="https://github.com/user-attachments/assets/ff17e6c0-2505-480e-ae25-e6f8309555bc"
/>
---------
Co-authored-by: Jordan Vidrine <jordan@jordanvidrine.com>
6.4 KiB
Vendored
DAccessControl Frontend Usage
Use this reference when adding or reviewing UI that lets users edit ACLs.
Component Contract
Import:
import DAccessControl from "discourse/ui-kit/d-access-control";
Basic usage:
<DAccessControl
@groups={{this.site.groups}}
@acl={{field.value}}
@aclTarget="DiscourseKanban::Board"
@onChange={{this.aclChanged}}
@transformPermissionOptions={{this.transformPermissionOptions}}
/>
Arguments:
@groups: group records available for selection. Each group should haveid,name,full_name, andautomatic.@acl: flattened ACL entries from the backend or form state. The backend can emit group and user entries, and this component can add groups from the preloaded@groupslist plus user/group search results from the ACL grantee search endpoint.@onChange: called with the next flattened ACL array when the user adds/removes/changes a row.@aclTarget: optional key used to load mandatory ACL entries fromsite.access_control.mandatory_acland banned entries fromsite.access_control.banned_acl.@transformPermissionOptions: optional callback to customize default permission labels/descriptions or add target-specific permissions.
@aclTarget must match target_class.acl_target_key; by default this is the Ruby class name such as "DiscourseKanban::Board".
Controlled Component Behavior
DAccessControl is controlled by its parent. It calls @onChange(nextAcl) on user actions, and the parent must write the returned array back into form state.
Example:
@action
aclChanged(acl) {
this.formApi.set("acl", acl);
}
Mandatory ACL rows are injected for display from this.site.access_control. The component does not call @onChange during render when it injects mandatory rows. Backend saves must still call AccessControlListManager with the submitted ACL array so mandatory entries are injected server-side too.
Banned ACL rows are also read from this.site.access_control. The component filters matching permission options for the row's grantee by comparing permission, type, and id. This is only a UX guard; backend saves must still go through AccessControlListManager, which rejects banned entries.
Permission Options
Default permissions:
view, level 1edit, level 2remove, appended as a destructive option
Use @transformPermissionOptions for domain-specific copy or added permissions:
@action
transformPermissionOptions(options) {
const viewOption = options.find((option) => option.id === "view");
viewOption.description = i18n("plugin.target.permission_view_description");
options.push({
id: "manage",
level: 3,
name: i18n("plugin.target.permission_manager"),
description: i18n("plugin.target.permission_manager_description"),
});
return options;
}
Keep permission copy aligned with backend semantics. If a displayed manage role also requires a global site setting or staff gate, make that clear in the surrounding UI or choose a different label.
Target-specific options added via @transformPermissionOptions can still be banned for individual grantees. For example, a target may add manage and then define banned_acl entries that remove edit and manage from the anonymous_users auto group.
Row Behavior
- Rows are sorted with mandatory rows first, then by group name.
- Mandatory rows show a lock icon, are styled with
--mandatory, and have their permission select disabled. - A mandatory ACL replaces an existing row for the same type/id in the component's display list.
- Banned permissions are filtered per row only when the banned entry's
type,id, andpermissionmatch the row. - The remove action remains available unless the row is mandatory.
- Newly added regular groups default to
edit. - Read-only default auto groups (
anonymous_users,everyone,trust_level_0) default toview. - Already selected grantees are removed from the add-group chooser's preloaded and remote results.
- The add control uses
EmailGroupUserChooserthrough a DAccessControl-specific wrapper. Preloaded group results preserve numeric group IDs in the ACL payload while displaying group names. - Typed add-control searches call
/access-control/grantees/search, which returns{ users: [...], groups: [...] }scoped to the current user's visible users/groups. - User rows added from search keep
username,name, andavatar_templateon the ACL entry so the rendered row can pass them throughrowAsUsertodAvatar. - Group rows added from preloaded or remote results keep
name,flair_url,flair_bg_color, andflair_coloron the ACL entry so the rendered row can pass them toDAvatarFlair; groups withoutflair_urlrender the genericuser-groupicon. - Row DOM metadata uses
data-row-typeanddata-row-id; tests should not rely on the olddata-group-idattribute.
The component is still group-first for preloaded data and mandatory ACL injection. Backend ACL rows can include type: :user entries and lookup helpers understand them, but mandatory user ACL display still needs explicit UI support if a target defines user mandatory entries.
FormKit Integration
When used inside a FormKit custom field:
<form.Field
@name="acl"
@title={{i18n "plugin.target.access"}}
@description={{i18n "plugin.target.access_description"}}
@format="max"
@type="custom"
@validate={{this.validateAccess}}
as |field|
>
<field.Control>
<DAccessControl
@groups={{this.site.groups}}
@acl={{field.value}}
@aclTarget="Plugin::Target"
@onChange={{this.aclChanged}}
@transformPermissionOptions={{this.transformPermissionOptions}}
/>
</field.Control>
</form.Field>
Validate the form state client-side for user experience, but rely on server-side validation and AccessControlListManager for actual enforcement.
Testing
Core component tests live in frontend/discourse/tests/integration/components/d-access-control-test.gjs.
Consumer tests should cover:
- target-specific permission options are present
@aclTargetrenders mandatory rows fromsite.access_control@aclTargetfilters banned permissions fromsite.access_controlfor the matching grantee only- mandatory rows are locked and not duplicated
@onChangeupdates parent/form state when the user changes a row- default ACL construction for new records includes expected groups, if the consumer builds defaults
- selectors use
.d-access-control__row[data-row-type="group"][data-row-id="..."]for row assertions