Discourse/discourse
Discourse/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-09-06 10:50:21 +08:00
Code Packages Activity Actions 9

FIX: don't crash out searching for parent in oneboxer

Browse source
This commit is contained in:
Sam 2015-09-22 12:42:13 +10:00
parent 9cad925c67
commit 18a8853181
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
lib/oneboxer.rb
View file

@ -82,13 +82,14 @@ module Oneboxer
changed = false changed = false
Oneboxer.each_onebox_link(doc) do |url, element| Oneboxer.each_onebox_link(doc) do |url, element|
onebox, preview = yield(url,element) onebox, _preview = yield(url,element)
if onebox if onebox
parsed_onebox = Nokogiri::HTML::fragment(onebox) parsed_onebox = Nokogiri::HTML::fragment(onebox)
next unless parsed_onebox.children.count > 0 next unless parsed_onebox.children.count > 0
# special logic to strip empty p elements # special logic to strip empty p elements
if element.parent && if element.parent &&
element.parent.node_name &&
element.parent.node_name.downcase == "p" && element.parent.node_name.downcase == "p" &&
element.parent.children.count == 1 element.parent.children.count == 1
element = element.parent element = element.parent