From 18a8853181041a9b1cabb55d58f8c6f5cb84d9ff Mon Sep 17 00:00:00 2001 From: Sam Date: Tue, 22 Sep 2015 12:42:13 +1000 Subject: [PATCH] FIX: don't crash out searching for parent in oneboxer --- lib/oneboxer.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/oneboxer.rb b/lib/oneboxer.rb index dddaa66358e..50aa8bc7b06 100644 --- a/lib/oneboxer.rb +++ b/lib/oneboxer.rb @@ -82,13 +82,14 @@ module Oneboxer changed = false Oneboxer.each_onebox_link(doc) do |url, element| - onebox, preview = yield(url,element) + onebox, _preview = yield(url,element) if onebox parsed_onebox = Nokogiri::HTML::fragment(onebox) next unless parsed_onebox.children.count > 0 # special logic to strip empty p elements if element.parent && + element.parent.node_name && element.parent.node_name.downcase == "p" && element.parent.children.count == 1 element = element.parent