woocommerce/woocommerce
2
0
Fork 0
mirror of https://github.com/woocommerce/woocommerce.git synced 2025-09-04 11:06:25 +08:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

CYS: fix php warning raise by the Product Collection block (#43546)

Browse source 
* CYS: fix php warning raise by the Product Collection block

* fix typo

* Add changefile(s) from automation for the following project(s): woocommerce

---------

Co-authored-by: github-actions <github-actions@github.com>
This commit is contained in:
Luigi Teschio 2024-01-12 13:44:06 +01:00 • committed by GitHub
parent aa661f2234
commit 5edea79b41
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
plugins/woocommerce-admin/client/customize-store/assembler-hub/block-editor.tsx
View file

@ -155,9 +155,13 @@ export const BlockEditor = ( {} ) => {
<BlockPreview <BlockPreview
blocks={ renderedBlocks } blocks={ renderedBlocks }
onChange={ onChange={
// We only need to pass onChange for the logo screen so that logo block can be updated when we change the logo attributes in logo sidebar navigation screen component. // We need to pass onChange for the logo screen so that logo block can be updated when we change the logo attributes in logo sidebar navigation screen component.
// We also need to pass onChange for the assembler hub screen so when a block set an attribute during the block initialization, the block editor will be updated.
// For other screens, we don't need to pass onChange. Otherwise, we'll get a race condition issue where the block editor will be updated twice: once from the onChange in the sidebar component, and once from the onChange in the block editor component. // For other screens, we don't need to pass onChange. Otherwise, we'll get a race condition issue where the block editor will be updated twice: once from the onChange in the sidebar component, and once from the onChange in the block editor component.
urlParams.path === '/customize-store/assembler-hub/logo' [
'/customize-store/assembler-hub/logo',
'/customize-store/assembler-hub',
].includes( urlParams.path )
? onChange ? onChange
: undefined : undefined
} }

4
plugins/woocommerce/changelog/43546-42865-cys-php-warning-triggered-whenever-a-pattern-with-the-product-collection-block-is-inserted-via-the-assembler Normal file
View file

@ -0,0 +1,4 @@
Significance: minor
Type: fix
CYS: fix php warning raise by the Product Collection block.