From fc20b05de83612e7d65d93f1052b2634263bda4d Mon Sep 17 00:00:00 2001 From: Alex P Date: Thu, 25 Nov 2021 11:55:09 +0200 Subject: [PATCH] Use icons instead of yes/no For consistency with WC and to avoid translation --- modules/ppcp-status-report/src/Renderer.php | 2 +- .../src/StatusReportModule.php | 26 +++++++++---------- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/modules/ppcp-status-report/src/Renderer.php b/modules/ppcp-status-report/src/Renderer.php index 1435febd6..eefa70eea 100644 --- a/modules/ppcp-status-report/src/Renderer.php +++ b/modules/ppcp-status-report/src/Renderer.php @@ -41,7 +41,7 @@ class Renderer { - + esc_html__( 'Onboarded', 'woocommerce-paypal-payments' ), 'exported_label' => 'Onboarded', 'description' => esc_html__( 'Whether PayPal account is correctly configured or not.', 'woocommerce-paypal-payments' ), - 'value' => $this->bool_to_text( + 'value' => $this->bool_to_html( $this->onboarded( $bearer, $state ) ), ), @@ -96,7 +96,7 @@ class StatusReportModule implements ModuleInterface { 'label' => esc_html__( 'WooCommerce currency supported', 'woocommerce-paypal-payments' ), 'exported_label' => 'WooCommerce currency supported', 'description' => esc_html__( 'Whether PayPal supports the default store currency or not.', 'woocommerce-paypal-payments' ), - 'value' => $this->bool_to_text( + 'value' => $this->bool_to_html( $currency_support->supports_wc_currency() ), ), @@ -104,7 +104,7 @@ class StatusReportModule implements ModuleInterface { 'label' => esc_html__( 'PayPal card processing available in country', 'woocommerce-paypal-payments' ), 'exported_label' => 'PayPal card processing available in country', 'description' => esc_html__( 'Whether PayPal card processing is available in country or not.', 'woocommerce-paypal-payments' ), - 'value' => $this->bool_to_text( + 'value' => $this->bool_to_html( $dcc_applies->for_country_currency() ), ), @@ -112,7 +112,7 @@ class StatusReportModule implements ModuleInterface { 'label' => esc_html__( 'Pay Later messaging available in country', 'woocommerce-paypal-payments' ), 'exported_label' => 'Pay Later messaging available in country', 'description' => esc_html__( 'Whether Pay Later is available in country or not.', 'woocommerce-paypal-payments' ), - 'value' => $this->bool_to_text( + 'value' => $this->bool_to_html( $messages_apply->for_country() ), ), @@ -120,13 +120,13 @@ class StatusReportModule implements ModuleInterface { 'label' => esc_html__( 'Webhook status', 'woocommerce-paypal-payments' ), 'exported_label' => 'Webhook status', 'description' => esc_html__( 'Whether we received webhooks successfully.', 'woocommerce-paypal-payments' ), - 'value' => $last_webhook_storage->is_empty() ? 'Unknown' : 'OK', + 'value' => $this->bool_to_html( ! $last_webhook_storage->is_empty() ), ), array( 'label' => esc_html__( 'Vault enabled', 'woocommerce-paypal-payments' ), 'exported_label' => 'Vault enabled', 'description' => esc_html__( 'Whether vaulting is enabled on PayPal account or not.', 'woocommerce-paypal-payments' ), - 'value' => $this->bool_to_text( + 'value' => $this->bool_to_html( $this->vault_enabled( $bearer ) ), ), @@ -134,7 +134,7 @@ class StatusReportModule implements ModuleInterface { 'label' => esc_html__( 'Logging enabled', 'woocommerce-paypal-payments' ), 'exported_label' => 'Logging enabled', 'description' => esc_html__( 'Whether logging of plugin events and errors is enabled.', 'woocommerce-paypal-payments' ), - 'value' => $this->bool_to_text( + 'value' => $this->bool_to_html( $settings->has( 'logging_enabled' ) && $settings->get( 'logging_enabled' ) ), ), @@ -142,7 +142,7 @@ class StatusReportModule implements ModuleInterface { 'label' => esc_html__( 'Reference Transactions', 'woocommerce-paypal-payments' ), 'exported_label' => 'Reference Transactions', 'description' => esc_html__( 'Whether Reference Transactions are enabled for the connected account', 'woocommerce-paypal-payments' ), - 'value' => $this->bool_to_text( + 'value' => $this->bool_to_html( $this->reference_transaction_enabled( $billing_agreements_endpoint ) ), ), @@ -150,7 +150,7 @@ class StatusReportModule implements ModuleInterface { 'label' => esc_html__( 'Used PayPal Checkout plugin', 'woocommerce-paypal-payments' ), 'exported_label' => 'Used PayPal Checkout plugin', 'description' => esc_html__( 'Whether the PayPal Checkout Gateway plugin was configured previously or not', 'woocommerce-paypal-payments' ), - 'value' => $this->bool_to_text( + 'value' => $this->bool_to_html( $had_ppec_plugin ), ), @@ -218,14 +218,14 @@ class StatusReportModule implements ModuleInterface { } /** - * Converts the bool value to "Yes" or "No". + * Converts the bool value to "yes" icon or dash. * * @param bool $value The value. * @return string */ - private function bool_to_text( bool $value ): string { + private function bool_to_html( bool $value ): string { return $value - ? esc_html__( 'Yes', 'woocommerce-paypal-payments' ) - : esc_html__( 'No', 'woocommerce-paypal-payments' ); + ? '' + : '–'; } }