woocommerce/woocommerce-paypal-payments
2
0
Fork 0
mirror of https://github.com/woocommerce/woocommerce-paypal-payments.git synced 2025-09-05 08:59:14 +08:00
Code Issues Projects Packages Wiki Activity Actions 7

♻️ Chore: Make isInitialized flag private

Browse source 
Reason: The button instance is added to the global document scope, this helps to protect internal component state
This commit is contained in:
Philipp Stracker 2024-07-24 14:20:40 +02:00
parent a473459ddb
commit f4abf7028e
No known key found for this signature in database
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
modules/ppcp-applepay/resources/js/ApplepayButton.js
View file

@ -40,7 +40,7 @@ class ApplePayButton {
*
* @type {boolean}
*/
isInitialized = false;
#isInitialized = false;
/**
* Context describes the button's location on the website and what details it submits.
@ -115,7 +115,7 @@ class ApplePayButton {
* @return {boolean} True, if the button can be displayed.
*/
get isEligible() {
if ( ! this.isInitialized ) {
if ( ! this.#isInitialized ) {
return true;
}
@ -127,7 +127,7 @@ class ApplePayButton {
}
init( config ) {
if ( this.isInitialized ) {
if ( this.#isInitialized ) {
return;
}
@ -138,7 +138,7 @@ class ApplePayButton {
this.log( 'Init', this.context );
this.initEventHandlers();
this.isInitialized = true;
this.#isInitialized = true;
this.applePayConfig = config;
const idMinicart = this.buttonConfig.button.mini_cart_wrapper;
@ -178,7 +178,7 @@ class ApplePayButton {
return;
}
this.isInitialized = false;
this.#isInitialized = false;
this.init( this.applePayConfig );
}