woocommerce/woocommerce-paypal-payments
2
0
Fork 0
mirror of https://github.com/woocommerce/woocommerce-paypal-payments.git synced 2025-09-07 19:54:15 +08:00
Code Issues Projects Packages Wiki Activity Actions

Merge branch 'trunk' into PCP-991-detach-vaulting-from-wc-subscriptions-support

Browse source
This commit is contained in:
Emili Castells Guasch 2023-05-16 09:56:32 +02:00
commit f40ca96b87
3 changed files with 35 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

20
modules/ppcp-webhooks/src/IncomingWebhookEndpoint.php
View file

@ -83,6 +83,14 @@ class IncomingWebhookEndpoint {
*/
private $last_webhook_event_storage;
/**
* Cached webhook verification results
* to avoid repeating requests when permission_callback is called multiple times.
*
* @var array<string, bool>
*/
private $verification_results = array();
/**
* IncomingWebhookEndpoint constructor.
*
@ -160,7 +168,17 @@ class IncomingWebhookEndpoint {
try {
$event = $this->event_from_request( $request );
} catch ( RuntimeException $exception ) {
$this->logger->error( 'Webhook parsing failed: ' . $exception->getMessage() );
return false;
}
$cache_key = $event->id();
if ( isset( $this->verification_results[ $cache_key ] ) ) {
return $this->verification_results[ $cache_key ];
}
try {
if ( $this->simulation->is_simulation_event( $event ) ) {
return true;
}
@ -169,9 +187,11 @@ class IncomingWebhookEndpoint {
if ( ! $result ) {
$this->logger->error( 'Webhook verification failed.' );
}
$this->verification_results[ $cache_key ] = $result;
return $result;
} catch ( RuntimeException $exception ) {
$this->logger->error( 'Webhook verification failed: ' . $exception->getMessage() );
$this->verification_results[ $cache_key ] = false;
return false;
}
}