From e95321cf82db67461f6894686624c63021016e08 Mon Sep 17 00:00:00 2001
From: Philipp Stracker
Date: Wed, 9 Oct 2024 14:04:21 +0200
Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20Fix=20incorrect=20validation=20r?=
=?UTF-8?q?ule?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
---
modules/ppcp-applepay/resources/js/ApplepayButton.js | 2 +-
.../ppcp-button/resources/js/modules/Renderer/PaymentButton.js | 1 +
modules/ppcp-googlepay/resources/js/GooglepayButton.js | 2 +-
3 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/modules/ppcp-applepay/resources/js/ApplepayButton.js b/modules/ppcp-applepay/resources/js/ApplepayButton.js
index 89634747a..ef94197e0 100644
--- a/modules/ppcp-applepay/resources/js/ApplepayButton.js
+++ b/modules/ppcp-applepay/resources/js/ApplepayButton.js
@@ -220,7 +220,7 @@ class ApplePayButton extends PaymentButton {
registerValidationRules( invalidIf, validIf ) {
invalidIf(
() =>
- [ 'TEST', 'PRODUCTION' ].includes(
+ ! [ 'TEST', 'PRODUCTION' ].includes(
this.buttonConfig.environment
),
`Invalid environment: ${ this.buttonConfig.environment }`
diff --git a/modules/ppcp-button/resources/js/modules/Renderer/PaymentButton.js b/modules/ppcp-button/resources/js/modules/Renderer/PaymentButton.js
index 35d938b34..aa6b80301 100644
--- a/modules/ppcp-button/resources/js/modules/Renderer/PaymentButton.js
+++ b/modules/ppcp-button/resources/js/modules/Renderer/PaymentButton.js
@@ -683,6 +683,7 @@ export default class PaymentButton {
* @param {(condition: () => boolean, errorMessage: string) => void} invalidIf - Registers a validation step that fails if the condition returns true.
* @param {(condition: () => boolean) => void} validIf - Registers a validation step that passes if the condition returns true.
*/
+ // eslint-disable-next-line no-unused-vars
registerValidationRules( invalidIf, validIf ) {}
/**
diff --git a/modules/ppcp-googlepay/resources/js/GooglepayButton.js b/modules/ppcp-googlepay/resources/js/GooglepayButton.js
index 0cd2bab70..83416b149 100644
--- a/modules/ppcp-googlepay/resources/js/GooglepayButton.js
+++ b/modules/ppcp-googlepay/resources/js/GooglepayButton.js
@@ -218,7 +218,7 @@ class GooglepayButton extends PaymentButton {
registerValidationRules( invalidIf, validIf ) {
invalidIf(
() =>
- [ 'TEST', 'PRODUCTION' ].includes(
+ ! [ 'TEST', 'PRODUCTION' ].includes(
this.buttonConfig.environment
),
`Invalid environment: ${ this.buttonConfig.environment }`