woocommerce/woocommerce-paypal-payments
2
0
Fork 0
mirror of https://github.com/woocommerce/woocommerce-paypal-payments.git synced 2025-09-06 14:57:26 +08:00
Code Issues Projects Packages Wiki Activity Actions

🥅 Add detection for accessing undefined props

Browse source
This commit is contained in:
Philipp Stracker 2025-01-16 20:02:37 +01:00
parent 033b6e5b74
commit dac414433f
No known key found for this signature in database
2 changed files with 12 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
modules/ppcp-settings/resources/js/data/styling/hooks.js
View file

@ -42,6 +42,11 @@ const useHooks = () => {
const getLocationProp = useCallback( const getLocationProp = useCallback(
( prop ) => { ( prop ) => {
if ( undefined === persistentData[ location ]?.[ prop ] ) {
console.error(
`Trying to access non-existent style property: ${ location }.${ prop }. Possibly wrong style name - review the reducer.`
);
}
return persistentData[ location ]?.[ prop ]; return persistentData[ location ]?.[ prop ];
}, },
[ location, persistentData ] [ location, persistentData ]

8
modules/ppcp-settings/resources/js/data/utils.js
View file

@ -107,7 +107,13 @@ export const createHooksForStore = ( storeName ) => {
`Please create the selector "${ selector }" for store "${ storeName }"` `Please create the selector "${ selector }" for store "${ storeName }"`
); );
} }
return store[ selector ]()?.[ key ]; const selectorResult = store[ selector ]();
if ( undefined === selectorResult?.[ key ] ) {
console.error(
`Warning: ${ selector }()[${ key }] is undefined in store "${ storeName }". This may indicate a bug.`
);
}
return selectorResult?.[ key ];
}, },
[ key ] [ key ]
); );