From cea292684bb61a74c1f3f7f1e86b7ee670d4bcc5 Mon Sep 17 00:00:00 2001
From: Philipp Stracker
Date: Wed, 12 Jun 2024 11:27:59 +0200
Subject: [PATCH] =?UTF-8?q?=F0=9F=8E=A8=20Minor=20code=20structure=20chang?=
=?UTF-8?q?es?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
---
modules/ppcp-applepay/resources/js/boot-admin.js | 2 +-
.../resources/js/modules/Renderer/PreviewButton.js | 6 +++---
.../resources/js/modules/Renderer/PreviewButtonManager.js | 6 +++---
modules/ppcp-googlepay/resources/js/boot-admin.js | 2 +-
4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/modules/ppcp-applepay/resources/js/boot-admin.js b/modules/ppcp-applepay/resources/js/boot-admin.js
index 65b3a8b0a..a44c922bb 100644
--- a/modules/ppcp-applepay/resources/js/boot-admin.js
+++ b/modules/ppcp-applepay/resources/js/boot-admin.js
@@ -51,7 +51,7 @@ class ApplePayPreviewButtonManager extends PreviewButtonManager {
* @param {string} wrapperId - CSS ID of the wrapper element.
* @return {ApplePayPreviewButton}
*/
- createButtonInst(wrapperId) {
+ createButtonInstance(wrapperId) {
return new ApplePayPreviewButton({
selector: wrapperId,
apiConfig: this.apiConfig
diff --git a/modules/ppcp-button/resources/js/modules/Renderer/PreviewButton.js b/modules/ppcp-button/resources/js/modules/Renderer/PreviewButton.js
index 4b46b850f..ae4c5ec55 100644
--- a/modules/ppcp-button/resources/js/modules/Renderer/PreviewButton.js
+++ b/modules/ppcp-button/resources/js/modules/Renderer/PreviewButton.js
@@ -116,9 +116,9 @@ class PreviewButton {
const buttonWrapper = previewButtonConfig.button.wrapper.replace(/^#/, '')
const ppcpWrapper = this.ppcpConfig.button.wrapper.replace(/^#/, '')
-if (buttonWrapper === ppcpWrapper) {
-throw new Error(`[APM Preview Button] Infinite loop detected. Provide different selectors for the button/ppcp wrapper elements! Selector: "#${buttonWrapper}"`);
-}
+ if (buttonWrapper === ppcpWrapper) {
+ throw new Error(`[APM Preview Button] Infinite loop detected. Provide different selectors for the button/ppcp wrapper elements! Selector: "#${buttonWrapper}"`);
+ }
this.createButton(previewButtonConfig)
}
diff --git a/modules/ppcp-button/resources/js/modules/Renderer/PreviewButtonManager.js b/modules/ppcp-button/resources/js/modules/Renderer/PreviewButtonManager.js
index d17a705fe..de65078b6 100644
--- a/modules/ppcp-button/resources/js/modules/Renderer/PreviewButtonManager.js
+++ b/modules/ppcp-button/resources/js/modules/Renderer/PreviewButtonManager.js
@@ -59,8 +59,8 @@ class PreviewButtonManager {
* @param {string} wrapperId - CSS ID of the wrapper element.
* @return {PreviewButton}
*/
- createButtonInst(wrapperId) {
- throw new Error('The "createButtonInst" method must be implemented by the derived class');
+ createButtonInstance(wrapperId) {
+ throw new Error('The "createButtonInstance" method must be implemented by the derived class');
}
registerEventListeners() {
@@ -183,7 +183,7 @@ class PreviewButtonManager {
#addButton(id, ppcpConfig) {
const createButton = () => {
if (!this.buttons[id]) {
- this.buttons[id] = this.createButtonInst(id).setButtonConfig(this.buttonConfig);
+ this.buttons[id] = this.createButtonInstance(id).setButtonConfig(this.buttonConfig);
}
this.#configureButton(id, ppcpConfig);
diff --git a/modules/ppcp-googlepay/resources/js/boot-admin.js b/modules/ppcp-googlepay/resources/js/boot-admin.js
index 909836f92..8de33a224 100644
--- a/modules/ppcp-googlepay/resources/js/boot-admin.js
+++ b/modules/ppcp-googlepay/resources/js/boot-admin.js
@@ -51,7 +51,7 @@ class GooglePayPreviewButtonManager extends PreviewButtonManager {
* @param {string} wrapperId - CSS ID of the wrapper element.
* @return {GooglePayPreviewButton}
*/
- createButtonInst(wrapperId) {
+ createButtonInstance(wrapperId) {
return new GooglePayPreviewButton({
selector: wrapperId,
apiConfig: this.apiConfig