From cc79f62cab6b5346aaf347906ccd441589bbca48 Mon Sep 17 00:00:00 2001 From: Pedro Silva Date: Tue, 25 Jul 2023 08:35:07 +0100 Subject: [PATCH] * Remove commented code --- .../resources/js/modules/Renderer/MessageRenderer.js | 2 -- .../resources/js/modules/Renderer/Renderer.js | 10 +--------- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/modules/ppcp-button/resources/js/modules/Renderer/MessageRenderer.js b/modules/ppcp-button/resources/js/modules/Renderer/MessageRenderer.js index 45f67ac67..afbb55efa 100644 --- a/modules/ppcp-button/resources/js/modules/Renderer/MessageRenderer.js +++ b/modules/ppcp-button/resources/js/modules/Renderer/MessageRenderer.js @@ -32,8 +32,6 @@ class MessageRenderer { widgetBuilder.registerMessages(this.config.wrapper, options); widgetBuilder.renderMessages(this.config.wrapper); - - // paypal.Messages(options).render(this.config.wrapper); } optionsEqual(options) { diff --git a/modules/ppcp-button/resources/js/modules/Renderer/Renderer.js b/modules/ppcp-button/resources/js/modules/Renderer/Renderer.js index 82caceea4..629c1abc9 100644 --- a/modules/ppcp-button/resources/js/modules/Renderer/Renderer.js +++ b/modules/ppcp-button/resources/js/modules/Renderer/Renderer.js @@ -119,15 +119,7 @@ class Renderer { } } - isAlreadyRendered(wrapper, fundingSource, hasEnabledSeparateGateways) { - // Simply check that has child nodes when we do not need to render buttons separately, - // this will reduce the risk of breaking with different themes/plugins - // and on the cart page (where we also do not need to render separately), which may fully reload this part of the page. - // Ideally we should also find a way to detect such full reloads and remove the corresponding keys from the set. - - // if (!hasEnabledSeparateGateways) { - // return document.querySelector(wrapper).hasChildNodes(); - // } + isAlreadyRendered(wrapper, fundingSource) { return this.renderedSources.has(wrapper + (fundingSource ?? '')); }