♻️ Rename store selectors

Selectors now only differentiate between persistent or transient data
This commit is contained in:
Philipp Stracker 2024-10-23 18:11:09 +02:00
parent a0dcfc1bad
commit c5e8a85acf
No known key found for this signature in database
4 changed files with 12 additions and 10 deletions

View file

@ -78,7 +78,7 @@ export function* persist() {
try { try {
const path = `${ NAMESPACE }/onboarding`; const path = `${ NAMESPACE }/onboarding`;
const data = select( STORE_NAME ).getOnboardingData(); const data = select( STORE_NAME ).getPersistentData();
yield updateIsSaving( true ); yield updateIsSaving( true );

View file

@ -9,20 +9,21 @@ export const useOnboardingDetails = () => {
persist, persist,
} = useDispatch( STORE_NAME ); } = useDispatch( STORE_NAME );
// Transient accessors.
const isSaving = useSelect( ( select ) => { const isSaving = useSelect( ( select ) => {
return select( STORE_NAME ).isSaving(); return select( STORE_NAME ).getTransientData().isSaving;
}, [] ); }, [] );
const onboardingStep = useSelect( ( select ) => { const onboardingStep = useSelect( ( select ) => {
return select( STORE_NAME ).getOnboardingData().step || 0; return select( STORE_NAME ).getPersistentData().step || 0;
}, [] ); }, [] );
const isSandboxMode = useSelect( ( select ) => { const isSandboxMode = useSelect( ( select ) => {
return select( STORE_NAME ).getOnboardingData().useSandbox; return select( STORE_NAME ).getPersistentData().useSandbox;
}, [] ); }, [] );
const isManualConnectionMode = useSelect( ( select ) => { const isManualConnectionMode = useSelect( ( select ) => {
return select( STORE_NAME ).getOnboardingData().useManualConnection; return select( STORE_NAME ).getPersistentData().useManualConnection;
}, [] ); }, [] );
const setDetailAndPersist = async ( setter, value ) => { const setDetailAndPersist = async ( setter, value ) => {

View file

@ -7,7 +7,7 @@ import { updateOnboardingDetails } from './actions';
/** /**
* Retrieve settings from the site's REST API. * Retrieve settings from the site's REST API.
*/ */
export function* getOnboardingData() { export function* getPersistentData() {
const path = `${ NAMESPACE }/onboarding`; const path = `${ NAMESPACE }/onboarding`;
try { try {

View file

@ -1,4 +1,4 @@
const EMPTY_OBJ = {}; const EMPTY_OBJ = Object.freeze( {} );
const getOnboardingState = ( state ) => { const getOnboardingState = ( state ) => {
if ( ! state ) { if ( ! state ) {
@ -8,10 +8,11 @@ const getOnboardingState = ( state ) => {
return state.onboarding || EMPTY_OBJ; return state.onboarding || EMPTY_OBJ;
}; };
export const getOnboardingData = ( state ) => { export const getPersistentData = ( state ) => {
return getOnboardingState( state ).data || EMPTY_OBJ; return getOnboardingState( state ).data || EMPTY_OBJ;
}; };
export const isSaving = ( state ) => { export const getTransientData = ( state ) => {
return getOnboardingState( state ).isSaving || false; const { data, ...transientState } = getOnboardingState( state );
return transientState || EMPTY_OBJ;
}; };