woocommerce/woocommerce-paypal-payments
2
0
Fork 0
mirror of https://github.com/woocommerce/woocommerce-paypal-payments.git synced 2025-09-06 14:57:26 +08:00
Code Issues Projects Packages Wiki Activity Actions

PHPCS fixes

Browse source
This commit is contained in:
Daniel Dudzic 2025-01-20 10:25:06 +01:00
parent 7f1a0c4b48
commit bbd707c12c
No known key found for this signature in database
GPG key ID: 31B40D33E3465483
1 changed files with 12 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

25
modules/ppcp-settings/src/Endpoint/SettingsRestEndpoint.php
View file

@ -7,7 +7,6 @@
* *
* @package WooCommerce\PayPalCommerce\Settings\Endpoint * @package WooCommerce\PayPalCommerce\Settings\Endpoint
*/ */
declare(strict_types=1); declare(strict_types=1);
namespace WooCommerce\PayPalCommerce\Settings\Endpoint; namespace WooCommerce\PayPalCommerce\Settings\Endpoint;
@ -23,6 +22,7 @@ use WP_REST_Response;
* Handles REST API endpoints for managing PayPal settings (Settings Tab). * Handles REST API endpoints for managing PayPal settings (Settings Tab).
*/ */
class SettingsRestEndpoint extends RestEndpoint { class SettingsRestEndpoint extends RestEndpoint {
/** /**
* The REST API endpoint base. * The REST API endpoint base.
* *
@ -54,15 +54,15 @@ class SettingsRestEndpoint extends RestEndpoint {
/** /**
* SettingsRestEndpoint constructor. * SettingsRestEndpoint constructor.
* *
* @param SettingsModel $settings The settings model instance. * @param SettingsModel $settings The settings model instance.
* @param LoggerInterface $logger The logger instance. * @param LoggerInterface $logger The logger instance.
*/ */
public function __construct( public function __construct(
SettingsModel $settings, SettingsModel $settings,
LoggerInterface $logger LoggerInterface $logger
) { ) {
$this->settings = $settings; $this->settings = $settings;
$this->logger = $logger; $this->logger = $logger;
} }
/** /**
@ -92,26 +92,26 @@ class SettingsRestEndpoint extends RestEndpoint {
* *
* @param WP_REST_Request $request The request instance. * @param WP_REST_Request $request The request instance.
* @return WP_REST_Response The response containing settings data or error details. * @return WP_REST_Response The response containing settings data or error details.
* @throws \Exception When encoding settings data fails.
*/ */
public function get_settings( WP_REST_Request $request ): WP_REST_Response { public function get_settings( WP_REST_Request $request ): WP_REST_Response {
try { try {
// Get settings data // Get settings data.
$data = $this->settings->get(); $data = $this->settings->get();
// Ensure the data is JSON-encodable // Ensure the data is JSON-encodable.
$encoded = json_encode( $data ); $encoded = wp_json_encode( $data );
if ( $encoded === false ) { if ( $encoded === false ) {
throw new \Exception( 'Failed to encode settings data: ' . json_last_error_msg() ); throw new \Exception( 'Failed to encode settings data: ' . json_last_error_msg() );
} }
// Create response with pre-verified JSON data // Create response with pre-verified JSON data.
$response_data = array( $response_data = array(
'success' => true, 'success' => true,
'data' => json_decode( $encoded, true ), 'data' => json_decode( $encoded, true ),
); );
return new WP_REST_Response( $response_data, 200 ); return new WP_REST_Response( $response_data, 200 );
} catch ( \Exception $error ) { } catch ( \Exception $error ) {
return new WP_REST_Response( return new WP_REST_Response(
array( array(
@ -128,16 +128,16 @@ class SettingsRestEndpoint extends RestEndpoint {
* *
* @param WP_REST_Request $request The request instance containing new settings. * @param WP_REST_Request $request The request instance containing new settings.
* @return WP_REST_Response The response containing updated settings or error details. * @return WP_REST_Response The response containing updated settings or error details.
* @throws \Exception When encoding updated settings fails.
*/ */
public function update_settings( WP_REST_Request $request ): WP_REST_Response { public function update_settings( WP_REST_Request $request ): WP_REST_Response {
try { try {
$data = $request->get_json_params(); $data = $request->get_json_params();
$this->settings->update( $data ); $this->settings->update( $data );
$updated_data = $this->settings->get(); $updated_data = $this->settings->get();
// Verify JSON encoding // Verify JSON encoding.
$encoded = json_encode( $updated_data ); $encoded = wp_json_encode( $updated_data );
if ( $encoded === false ) { if ( $encoded === false ) {
throw new \Exception( 'Failed to encode updated settings: ' . json_last_error_msg() ); throw new \Exception( 'Failed to encode updated settings: ' . json_last_error_msg() );
} }
@ -149,7 +149,6 @@ class SettingsRestEndpoint extends RestEndpoint {
), ),
200 200
); );
} catch ( \Exception $error ) { } catch ( \Exception $error ) {
return new WP_REST_Response( return new WP_REST_Response(
array( array(