woocommerce/woocommerce-paypal-payments
2
0
Fork 0
mirror of https://github.com/woocommerce/woocommerce-paypal-payments.git synced 2025-09-06 12:25:15 +08:00
Code Issues Projects Packages Wiki Activity Actions 7

Simplify null breakdown check

Browse source 
If it is null, we would return false either way.
Also why suddenly use $this->amount() if it is passed as parameter.
This commit is contained in:
Alex P 2021-10-28 17:39:33 +03:00
parent 0460342b41
commit b7f628c8c7
1 changed files with 8 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

17
modules/ppcp-api-client/src/Entity/PurchaseUnit.php
View file

@ -303,10 +303,13 @@ class PurchaseUnit {
* @return bool
*/
private function ditch_items_when_mismatch( Amount $amount, Item ...$items ): bool {
$fee_items_total = ( $amount->breakdown() && $amount->breakdown()->item_total() ) ?
$amount->breakdown()->item_total()->value() : null;
$fee_tax_total = ( $amount->breakdown() && $amount->breakdown()->tax_total() ) ?
$amount->breakdown()->tax_total()->value() : null;
$breakdown = $amount->breakdown();
if ( ! $breakdown ) {
return false;
}
$fee_items_total = $breakdown->item_total() ? $breakdown->item_total()->value() : null;
$fee_tax_total = $breakdown->tax_total() ? $breakdown->tax_total()->value() : null;
foreach ( $items as $item ) {
if ( null !== $fee_items_total ) {
@ -324,10 +327,6 @@ class PurchaseUnit {
return true;
}
$breakdown = $this->amount()->breakdown();
if ( ! $breakdown ) {
return false;
}
$amount_total = 0;
if ( $breakdown->shipping() ) {
$amount_total += $breakdown->shipping()->value();
@ -351,7 +350,7 @@ class PurchaseUnit {
$amount_total += $breakdown->insurance()->value();
}
$amount_value = $this->amount()->value();
$amount_value = $amount->value();
$needs_to_ditch = (string) $amount_total !== (string) $amount_value;
return $needs_to_ditch;
}