woocommerce/woocommerce-paypal-payments
2
0
Fork 0
mirror of https://github.com/woocommerce/woocommerce-paypal-payments.git synced 2025-09-05 08:59:14 +08:00
Code Issues Projects Packages Wiki Activity Actions 7

♻️ Make code more readable, resolve one warning

Browse source
This commit is contained in:
Philipp Stracker 2025-03-18 14:53:49 +01:00
parent 122be6dcd7
commit b5c08e842e
No known key found for this signature in database
2 changed files with 8 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
modules/ppcp-button/resources/js/modules/Renderer/Renderer.js
View file

@ -214,7 +214,9 @@ class Renderer {
} }
); );
this.renderedSources.add( wrapper + ( fundingSource ?? '' ) ); this.renderedSources.add(
wrapper + ( fundingSource ? fundingSource : '' )
);
if ( window.paypal?.Buttons ) { if ( window.paypal?.Buttons ) {
widgetBuilder.registerButtons( widgetBuilder.registerButtons(

9
modules/ppcp-button/resources/js/modules/Renderer/WidgetBuilder.js
View file

@ -40,8 +40,9 @@ class WidgetBuilder {
renderButtons( wrapper ) { renderButtons( wrapper ) {
wrapper = this.sanitizeWrapper( wrapper ); wrapper = this.sanitizeWrapper( wrapper );
const entryKey = this.toKey( wrapper );
if ( ! this.buttons.has( this.toKey( wrapper ) ) ) { if ( ! this.buttons.has( entryKey ) ) {
return; return;
} }
@ -49,11 +50,11 @@ class WidgetBuilder {
return; return;
} }
const entry = this.buttons.get( this.toKey( wrapper ) ); const entry = this.buttons.get( entryKey );
const btn = this.paypal.Buttons( entry.options ); const btn = this.paypal.Buttons( entry.options );
if ( ! btn.isEligible() ) { if ( ! btn.isEligible() ) {
this.buttons.delete( this.toKey( wrapper ) ); this.buttons.delete( entryKey );
return; return;
} }
@ -67,7 +68,7 @@ class WidgetBuilder {
} }
renderAllButtons() { renderAllButtons() {
for ( const [ wrapper, entry ] of this.buttons ) { for ( const [ wrapper ] of this.buttons ) {
this.renderButtons( wrapper ); this.renderButtons( wrapper );
} }
} }