From 1d0d4d21adc2674796c07b2e438ae69657efcef2 Mon Sep 17 00:00:00 2001 From: Emili Castells Guasch Date: Thu, 20 Jun 2024 15:06:35 +0200 Subject: [PATCH 1/2] Ensure subscriptions mode setting exist --- .../src/PayPalSubscriptionsModule.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/modules/ppcp-paypal-subscriptions/src/PayPalSubscriptionsModule.php b/modules/ppcp-paypal-subscriptions/src/PayPalSubscriptionsModule.php index 094a922b9..787451551 100644 --- a/modules/ppcp-paypal-subscriptions/src/PayPalSubscriptionsModule.php +++ b/modules/ppcp-paypal-subscriptions/src/PayPalSubscriptionsModule.php @@ -102,7 +102,9 @@ class PayPalSubscriptionsModule implements ModuleInterface { $product = wc_get_product( $product_id ); $settings = $c->get( 'wcgateway.settings' ); - $subscriptions_mode = $settings->get( 'subscriptions_mode' ); + assert($settings instanceof Settings); + + $subscriptions_mode = $settings->has( 'subscriptions_mode' ) ? $settings->get( 'subscriptions_mode' ) : ''; if ( 'subscriptions_api' !== $subscriptions_mode ) { if ( $product && $product->get_sold_individually() ) { From 67074a6c9f1f189cbae1bdd95c33f28cad9910aa Mon Sep 17 00:00:00 2001 From: Emili Castells Guasch Date: Thu, 20 Jun 2024 15:07:34 +0200 Subject: [PATCH 2/2] Ensure subscriptions mode setting exist --- .../src/PayPalSubscriptionsModule.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/ppcp-paypal-subscriptions/src/PayPalSubscriptionsModule.php b/modules/ppcp-paypal-subscriptions/src/PayPalSubscriptionsModule.php index 787451551..7b0818115 100644 --- a/modules/ppcp-paypal-subscriptions/src/PayPalSubscriptionsModule.php +++ b/modules/ppcp-paypal-subscriptions/src/PayPalSubscriptionsModule.php @@ -101,8 +101,8 @@ class PayPalSubscriptionsModule implements ModuleInterface { $product = wc_get_product( $product_id ); - $settings = $c->get( 'wcgateway.settings' ); - assert($settings instanceof Settings); + $settings = $c->get( 'wcgateway.settings' ); + assert( $settings instanceof Settings ); $subscriptions_mode = $settings->has( 'subscriptions_mode' ) ? $settings->get( 'subscriptions_mode' ) : '';