From b3df9a5b47e966bcc998a8e181b328e01c6c4bd1 Mon Sep 17 00:00:00 2001
From: Alex P <alex.pantec@gmail.com>
Date: Mon, 31 Oct 2022 11:42:14 +0200
Subject: [PATCH] Fix err.details check, show message if no details

The array check was wrong, resulting in no message shown and an error about empty string.
Also we should output .message if no .details, or at least a generic message if no .message too
---
 .../resources/js/modules/Renderer/CreditCardRenderer.js     | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/modules/ppcp-button/resources/js/modules/Renderer/CreditCardRenderer.js b/modules/ppcp-button/resources/js/modules/Renderer/CreditCardRenderer.js
index 7e0b5a235..5c09b907d 100644
--- a/modules/ppcp-button/resources/js/modules/Renderer/CreditCardRenderer.js
+++ b/modules/ppcp-button/resources/js/modules/Renderer/CreditCardRenderer.js
@@ -233,8 +233,12 @@ class CreditCardRenderer {
                 this.spinner.unblock();
                 this.errorHandler.clear();
 
-                if (err.details) {
+                if (err.details?.length) {
                     this.errorHandler.message(err.details.map(d => `${d.issue} ${d.description}`).join('<br/>'), true);
+                } else if (err.message) {
+                    this.errorHandler.message(err.message, true);
+                } else {
+                    this.errorHandler.genericError();
                 }
             });
         } else {