From b25a124ffadc4c46445c74e8539bfb1e8f999d34 Mon Sep 17 00:00:00 2001 From: Pedro Silva Date: Thu, 27 Jul 2023 10:29:24 +0100 Subject: [PATCH] * Fix lint --- .../ppcp-button/src/Assets/SmartButton.php | 44 +++++++++++-------- .../src/Endpoint/SimulateCartEndpoint.php | 23 +++++----- 2 files changed, 38 insertions(+), 29 deletions(-) diff --git a/modules/ppcp-button/src/Assets/SmartButton.php b/modules/ppcp-button/src/Assets/SmartButton.php index bd1577e09..b40bfd266 100644 --- a/modules/ppcp-button/src/Assets/SmartButton.php +++ b/modules/ppcp-button/src/Assets/SmartButton.php @@ -1372,15 +1372,15 @@ class SmartButton implements SmartButtonInterface { /** * Fills and returns the product context_data array to be used in filters. * - * @param array $context_data + * @param array $context_data The context data for this filter. * @return array */ - private function product_filter_context_data( array $context_data = [] ): array { + private function product_filter_context_data( array $context_data = array() ): array { if ( ! isset( $context_data['product'] ) ) { $context_data['product'] = wc_get_product(); } if ( ! $context_data['product'] ) { - return []; + return array(); } if ( ! isset( $context_data['order_total'] ) && ( $context_data['product'] instanceof WC_Product ) ) { $context_data['order_total'] = (float) $context_data['product']->get_price( 'raw' ); @@ -1393,24 +1393,28 @@ class SmartButton implements SmartButtonInterface { * Checks if PayPal buttons/messages should be rendered for the current page. * * @param string|null $context The context that should be checked, use default otherwise. - * @param array $context_data The context data for this filter + * @param array $context_data The context data for this filter. * @return bool */ - public function is_button_disabled( string $context = null, array $context_data = [] ): bool { + public function is_button_disabled( string $context = null, array $context_data = array() ): bool { if ( null === $context ) { $context = $this->context(); } if ( 'product' === $context ) { - // Allows to decide if the button should be disabled for a given product. + /** + * Allows to decide if the button should be disabled for a given product. + */ return apply_filters( 'woocommerce_paypal_payments_product_buttons_disabled', false, - $this->product_filter_context_data($context_data) + $this->product_filter_context_data( $context_data ) ); } - // Allows to decide if the button should be disabled globally or on a given context. + /** + * Allows to decide if the button should be disabled globally or on a given context. + */ return apply_filters( 'woocommerce_paypal_payments_buttons_disabled', false, @@ -1422,21 +1426,25 @@ class SmartButton implements SmartButtonInterface { * Checks a filter if pay_later/messages should be rendered on a given location / context. * * @param string $location The location. - * @param array $context_data The context data for this filter + * @param array $context_data The context data for this filter. * @return bool */ - private function is_pay_later_filter_enabled_for_location( string $location, array $context_data = [] ): bool { + private function is_pay_later_filter_enabled_for_location( string $location, array $context_data = array() ): bool { if ( 'product' === $location ) { - // Allows to decide if the button should be disabled for a given product. + /** + * Allows to decide if the button should be disabled for a given product. + */ return ! apply_filters( 'woocommerce_paypal_payments_product_buttons_paylater_disabled', false, - $this->product_filter_context_data($context_data) + $this->product_filter_context_data( $context_data ) ); } - // Allows to decide if the button should be disabled on a given context. + /** + * Allows to decide if the button should be disabled on a given context. + */ return ! apply_filters( 'woocommerce_paypal_payments_buttons_paylater_disabled', false, @@ -1448,10 +1456,10 @@ class SmartButton implements SmartButtonInterface { * Check whether Pay Later button is enabled for a given location. * * @param string $location The location. - * @param array $context_data The context data for this filter + * @param array $context_data The context data for this filter. * @return bool true if is enabled, otherwise false. */ - public function is_pay_later_button_enabled_for_location( string $location, array $context_data = [] ): bool { + public function is_pay_later_button_enabled_for_location( string $location, array $context_data = array() ): bool { return $this->is_pay_later_filter_enabled_for_location( $location, $context_data ) && $this->settings_status->is_pay_later_button_enabled_for_location( $location ); @@ -1460,11 +1468,11 @@ class SmartButton implements SmartButtonInterface { /** * Check whether Pay Later message is enabled for a given location. * - * @param string $location The location setting name. - * @param array $context_data The context data for this filter + * @param string $location The location setting name. + * @param array $context_data The context data for this filter. * @return bool true if is enabled, otherwise false. */ - public function is_pay_later_messaging_enabled_for_location( string $location, array $context_data = [] ): bool { + public function is_pay_later_messaging_enabled_for_location( string $location, array $context_data = array() ): bool { return $this->is_pay_later_filter_enabled_for_location( $location, $context_data ) && $this->settings_status->is_pay_later_messaging_enabled_for_location( $location ); } diff --git a/modules/ppcp-button/src/Endpoint/SimulateCartEndpoint.php b/modules/ppcp-button/src/Endpoint/SimulateCartEndpoint.php index 62defeec6..5e3796dbb 100644 --- a/modules/ppcp-button/src/Endpoint/SimulateCartEndpoint.php +++ b/modules/ppcp-button/src/Endpoint/SimulateCartEndpoint.php @@ -85,32 +85,33 @@ class SimulateCartEndpoint extends AbstractCartEndpoint { unset( $this->cart ); // Process filters. - $pay_later_enabled = true; + $pay_later_enabled = true; $pay_later_messaging_enabled = true; - $button_enabled = true; + $button_enabled = true; foreach ( $products as $product ) { - $context_data = [ - 'product' => $product['product'], + $context_data = array( + 'product' => $product['product'], 'order_total' => $total, - ]; - $pay_later_enabled = $pay_later_enabled && $this->smart_button->is_pay_later_button_enabled_for_location( 'product', $context_data ); + ); + + $pay_later_enabled = $pay_later_enabled && $this->smart_button->is_pay_later_button_enabled_for_location( 'product', $context_data ); $pay_later_messaging_enabled = $pay_later_messaging_enabled && $this->smart_button->is_pay_later_messaging_enabled_for_location( 'product', $context_data ); - $button_enabled = $button_enabled && ! $this->smart_button->is_button_disabled( 'product', $context_data ); + $button_enabled = $button_enabled && ! $this->smart_button->is_button_disabled( 'product', $context_data ); } wp_send_json_success( array( - 'total' => $total, - 'funding' => array( + 'total' => $total, + 'funding' => array( 'paylater' => array( 'enabled' => $pay_later_enabled, ), ), - 'button' => array( + 'button' => array( 'is_disabled' => ! $button_enabled, ), - 'messages' => array( + 'messages' => array( 'is_hidden' => ! $pay_later_messaging_enabled, ), )