From 25709e2f8dcbb611b7dc910d79daf2704255a482 Mon Sep 17 00:00:00 2001
From: carmenmaymo <mayen22@gmail.com>
Date: Mon, 17 Feb 2025 14:04:34 +0100
Subject: [PATCH 1/2] Add wp_set_script_translations to settings module

---
 modules/ppcp-settings/src/SettingsModule.php | 19 +++++++++++++++----
 1 file changed, 15 insertions(+), 4 deletions(-)

diff --git a/modules/ppcp-settings/src/SettingsModule.php b/modules/ppcp-settings/src/SettingsModule.php
index 1e6c1f818..6c84c5964 100644
--- a/modules/ppcp-settings/src/SettingsModule.php
+++ b/modules/ppcp-settings/src/SettingsModule.php
@@ -106,7 +106,11 @@ class SettingsModule implements ServiceModule, ExecutableModule {
 						)
 					);
 
-					wp_enqueue_script( 'ppcp-switch-settings-ui' );
+					wp_enqueue_script( 'ppcp-switch-settings-ui','',['wp-i18n'] );
+					wp_set_script_translations(
+						'ppcp-switch-settings-ui',
+						'woocommerce-paypal-payments',
+					);
 				}
 			);
 
@@ -159,7 +163,11 @@ class SettingsModule implements ServiceModule, ExecutableModule {
 					true
 				);
 
-				wp_enqueue_script( 'ppcp-admin-settings' );
+				wp_enqueue_script('ppcp-admin-settings', '', ['wp-i18n']);
+				wp_set_script_translations(
+					'ppcp-admin-settings',
+					'woocommerce-paypal-payments',
+				);
 
 				/**
 				 * Require resolves.
@@ -198,11 +206,14 @@ class SettingsModule implements ServiceModule, ExecutableModule {
 					wp_enqueue_script(
 						'ppcp-paylater-configurator-lib',
 						'https://www.paypalobjects.com/merchant-library/merchant-configurator.js',
-						array(),
+						['wp-i18n'],
 						$script_asset_file['version'],
 						true
 					);
-
+					wp_set_script_translations(
+						'ppcp-paylater-configurator-lib',
+						'woocommerce-paypal-payments',
+					);
 					$script_data['PcpPayLaterConfigurator'] = array(
 						'config'           => array(),
 						'merchantClientId' => $settings->get( 'client_id' ),

From c69e56e6423baca83aa7aaa61c8a49c355c11c5a Mon Sep 17 00:00:00 2001
From: carmenmaymo <mayen22@gmail.com>
Date: Wed, 19 Feb 2025 10:58:16 +0100
Subject: [PATCH 2/2] Fix CI

---
 modules/ppcp-settings/src/SettingsModule.php | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/modules/ppcp-settings/src/SettingsModule.php b/modules/ppcp-settings/src/SettingsModule.php
index 6c84c5964..01ca16f0d 100644
--- a/modules/ppcp-settings/src/SettingsModule.php
+++ b/modules/ppcp-settings/src/SettingsModule.php
@@ -106,7 +106,7 @@ class SettingsModule implements ServiceModule, ExecutableModule {
 						)
 					);
 
-					wp_enqueue_script( 'ppcp-switch-settings-ui','',['wp-i18n'] );
+					wp_enqueue_script( 'ppcp-switch-settings-ui', '', array( 'wp-i18n' ), $script_asset_file['version'] );
 					wp_set_script_translations(
 						'ppcp-switch-settings-ui',
 						'woocommerce-paypal-payments',
@@ -163,7 +163,7 @@ class SettingsModule implements ServiceModule, ExecutableModule {
 					true
 				);
 
-				wp_enqueue_script('ppcp-admin-settings', '', ['wp-i18n']);
+				wp_enqueue_script( 'ppcp-admin-settings', '', array( 'wp-i18n' ), $script_asset_file['version'] );
 				wp_set_script_translations(
 					'ppcp-admin-settings',
 					'woocommerce-paypal-payments',
@@ -206,7 +206,7 @@ class SettingsModule implements ServiceModule, ExecutableModule {
 					wp_enqueue_script(
 						'ppcp-paylater-configurator-lib',
 						'https://www.paypalobjects.com/merchant-library/merchant-configurator.js',
-						['wp-i18n'],
+						array( 'wp-i18n' ),
 						$script_asset_file['version'],
 						true
 					);