From ae2ce64b70f9e5fd4ea839d056680e3734ae5378 Mon Sep 17 00:00:00 2001 From: David Remer Date: Tue, 14 Apr 2020 10:43:36 +0300 Subject: [PATCH] use Mockery --- .../PHPUnit/Entity/AmountBreakdownTest.php | 29 ++++++++++--------- .../tests/PHPUnit/Entity/AmountTest.php | 9 +++--- .../Entity/ErrorResponseCollectionTest.php | 13 +++++---- .../PHPUnit/Entity/ErrorResponseTest.php | 1 + .../tests/PHPUnit/Entity/ItemTest.php | 13 +++++---- .../tests/PHPUnit/TestCase.php | 4 ++- 6 files changed, 38 insertions(+), 31 deletions(-) diff --git a/modules.local/ppcp-api-client/tests/PHPUnit/Entity/AmountBreakdownTest.php b/modules.local/ppcp-api-client/tests/PHPUnit/Entity/AmountBreakdownTest.php index f7779f5ae..144da841e 100644 --- a/modules.local/ppcp-api-client/tests/PHPUnit/Entity/AmountBreakdownTest.php +++ b/modules.local/ppcp-api-client/tests/PHPUnit/Entity/AmountBreakdownTest.php @@ -5,30 +5,31 @@ namespace Inpsyde\PayPalCommerce\ApiClient\Entity; use Inpsyde\PayPalCommerce\ApiClient\TestCase; +use Mockery; class AmountBreakdownTest extends TestCase { public function test() { - $itemTotal = \Mockery::mock(Money::class); + $itemTotal = Mockery::mock(Money::class); $itemTotal ->expects('toArray')->andReturn(['itemTotal']); - $shipping = \Mockery::mock(Money::class); + $shipping = Mockery::mock(Money::class); $shipping ->expects('toArray')->andReturn(['shipping']); - $taxTotal = \Mockery::mock(Money::class); + $taxTotal = Mockery::mock(Money::class); $taxTotal ->expects('toArray')->andReturn(['taxTotal']); - $handling = \Mockery::mock(Money::class); + $handling = Mockery::mock(Money::class); $handling ->expects('toArray')->andReturn(['handling']); - $insurance = \Mockery::mock(Money::class); + $insurance = Mockery::mock(Money::class); $insurance ->expects('toArray')->andReturn(['insurance']); - $shippingDiscount = \Mockery::mock(Money::class); + $shippingDiscount = Mockery::mock(Money::class); $shippingDiscount ->expects('toArray')->andReturn(['shippingDiscount']); - $discount = \Mockery::mock(Money::class); + $discount = Mockery::mock(Money::class); $discount ->expects('toArray')->andReturn(['discount']); $testee = new AmountBreakdown( @@ -67,25 +68,25 @@ class AmountBreakdownTest extends TestCase */ public function testDropArrayKeyIfNoValueGiven($keyMissing, $methodName) { - $itemTotal = \Mockery::mock(Money::class); + $itemTotal = Mockery::mock(Money::class); $itemTotal ->shouldReceive('toArray')->zeroOrMoreTimes()->andReturn(['itemTotal']); - $shipping = \Mockery::mock(Money::class); + $shipping = Mockery::mock(Money::class); $shipping ->shouldReceive('toArray')->zeroOrMoreTimes()->andReturn(['shipping']); - $taxTotal = \Mockery::mock(Money::class); + $taxTotal = Mockery::mock(Money::class); $taxTotal ->shouldReceive('toArray')->zeroOrMoreTimes()->andReturn(['taxTotal']); - $handling = \Mockery::mock(Money::class); + $handling = Mockery::mock(Money::class); $handling ->shouldReceive('toArray')->zeroOrMoreTimes()->andReturn(['handling']); - $insurance = \Mockery::mock(Money::class); + $insurance = Mockery::mock(Money::class); $insurance ->shouldReceive('toArray')->zeroOrMoreTimes()->andReturn(['insurance']); - $shippingDiscount = \Mockery::mock(Money::class); + $shippingDiscount = Mockery::mock(Money::class); $shippingDiscount ->shouldReceive('toArray')->zeroOrMoreTimes()->andReturn(['shippingDiscount']); - $discount = \Mockery::mock(Money::class); + $discount = Mockery::mock(Money::class); $discount ->shouldReceive('toArray')->zeroOrMoreTimes()->andReturn(['discount']); diff --git a/modules.local/ppcp-api-client/tests/PHPUnit/Entity/AmountTest.php b/modules.local/ppcp-api-client/tests/PHPUnit/Entity/AmountTest.php index a43c40112..1948ca4c3 100644 --- a/modules.local/ppcp-api-client/tests/PHPUnit/Entity/AmountTest.php +++ b/modules.local/ppcp-api-client/tests/PHPUnit/Entity/AmountTest.php @@ -5,12 +5,13 @@ namespace Inpsyde\PayPalCommerce\ApiClient\Entity; use Inpsyde\PayPalCommerce\ApiClient\TestCase; +use Mockery; class AmountTest extends TestCase { public function test() { - $money = \Mockery::mock(Money::class); + $money = Mockery::mock(Money::class); $money->shouldReceive('currencyCode')->andReturn('currencyCode'); $money->shouldReceive('value')->andReturn(1.10); $testee = new Amount($money); @@ -19,7 +20,7 @@ class AmountTest extends TestCase $this->assertEquals(1.10, $testee->value()); } public function testBreakdownIsNull() { - $money = \Mockery::mock(Money::class); + $money = Mockery::mock(Money::class); $money->shouldReceive('currencyCode')->andReturn('currencyCode'); $money->shouldReceive('value')->andReturn(1.10); $testee = new Amount($money); @@ -33,10 +34,10 @@ class AmountTest extends TestCase $this->assertEquals($expectedArray, $testee->toArray()); } public function testBreakdown() { - $money = \Mockery::mock(Money::class); + $money = Mockery::mock(Money::class); $money->shouldReceive('currencyCode')->andReturn('currencyCode'); $money->shouldReceive('value')->andReturn(1.10); - $breakdown = \Mockery::mock(AmountBreakdown::class); + $breakdown = Mockery::mock(AmountBreakdown::class); $breakdown->shouldReceive('toArray')->andReturn([1]); $testee = new Amount($money, $breakdown); diff --git a/modules.local/ppcp-api-client/tests/PHPUnit/Entity/ErrorResponseCollectionTest.php b/modules.local/ppcp-api-client/tests/PHPUnit/Entity/ErrorResponseCollectionTest.php index a7fb3546f..5224b2d0c 100644 --- a/modules.local/ppcp-api-client/tests/PHPUnit/Entity/ErrorResponseCollectionTest.php +++ b/modules.local/ppcp-api-client/tests/PHPUnit/Entity/ErrorResponseCollectionTest.php @@ -4,17 +4,18 @@ declare(strict_types=1); namespace Inpsyde\PayPalCommerce\ApiClient\Entity; use Inpsyde\PayPalCommerce\ApiClient\TestCase; +use Mockery; class ErrorResponseCollectionTest extends TestCase { public function testHasErrorCode() { - $error1 = \Mockery::mock(ErrorResponse::class); + $error1 = Mockery::mock(ErrorResponse::class); $error1 ->expects('code') ->times(3) ->andReturn('code-1'); - $error2 = \Mockery::mock(ErrorResponse::class); + $error2 = Mockery::mock(ErrorResponse::class); $error2 ->expects('code') ->times(3) @@ -25,11 +26,11 @@ class ErrorResponseCollectionTest extends TestCase $this->assertFalse($testee->hasErrorCode('code-3'), 'code-3 should not return true'); } public function testCodes() { - $error1 = \Mockery::mock(ErrorResponse::class); + $error1 = Mockery::mock(ErrorResponse::class); $error1 ->expects('code') ->andReturn('code-1'); - $error2 = \Mockery::mock(ErrorResponse::class); + $error2 = Mockery::mock(ErrorResponse::class); $error2 ->expects('code') ->andReturn('code-2'); @@ -38,8 +39,8 @@ class ErrorResponseCollectionTest extends TestCase $this->assertEquals($expected, $testee->codes()); } public function testErrors() { - $error1 = \Mockery::mock(ErrorResponse::class); - $error2 = \Mockery::mock(ErrorResponse::class); + $error1 = Mockery::mock(ErrorResponse::class); + $error2 = Mockery::mock(ErrorResponse::class); $testee = new ErrorResponseCollection($error1, $error2); $errors = $testee->errors(); diff --git a/modules.local/ppcp-api-client/tests/PHPUnit/Entity/ErrorResponseTest.php b/modules.local/ppcp-api-client/tests/PHPUnit/Entity/ErrorResponseTest.php index f7f288ca3..9172fe84f 100644 --- a/modules.local/ppcp-api-client/tests/PHPUnit/Entity/ErrorResponseTest.php +++ b/modules.local/ppcp-api-client/tests/PHPUnit/Entity/ErrorResponseTest.php @@ -4,6 +4,7 @@ declare(strict_types=1); namespace Inpsyde\PayPalCommerce\ApiClient\Entity; use Inpsyde\PayPalCommerce\ApiClient\TestCase; +use Mockery; class ErrorResponseTest extends TestCase { diff --git a/modules.local/ppcp-api-client/tests/PHPUnit/Entity/ItemTest.php b/modules.local/ppcp-api-client/tests/PHPUnit/Entity/ItemTest.php index d8c882bbe..4cb0dd0b4 100644 --- a/modules.local/ppcp-api-client/tests/PHPUnit/Entity/ItemTest.php +++ b/modules.local/ppcp-api-client/tests/PHPUnit/Entity/ItemTest.php @@ -4,13 +4,14 @@ declare(strict_types=1); namespace Inpsyde\PayPalCommerce\ApiClient\Entity; use Inpsyde\PayPalCommerce\ApiClient\TestCase; +use Mockery; class ItemTest extends TestCase { public function test() { - $unitAmount = \Mockery::mock(Money::class); - $tax = \Mockery::mock(Money::class); + $unitAmount = Mockery::mock(Money::class); + $tax = Mockery::mock(Money::class); $testee = new Item( 'name', $unitAmount, @@ -31,8 +32,8 @@ class ItemTest extends TestCase } public function testDigitalGoodsCategory() { - $unitAmount = \Mockery::mock(Money::class); - $tax = \Mockery::mock(Money::class); + $unitAmount = Mockery::mock(Money::class); + $tax = Mockery::mock(Money::class); $testee = new Item( 'name', $unitAmount, @@ -48,11 +49,11 @@ class ItemTest extends TestCase public function testToArray() { - $unitAmount = \Mockery::mock(Money::class); + $unitAmount = Mockery::mock(Money::class); $unitAmount ->expects('toArray') ->andReturn([1]); - $tax = \Mockery::mock(Money::class); + $tax = Mockery::mock(Money::class); $tax ->expects('toArray') ->andReturn([2]); diff --git a/modules.local/ppcp-api-client/tests/PHPUnit/TestCase.php b/modules.local/ppcp-api-client/tests/PHPUnit/TestCase.php index 636d9b01e..59f4b00c0 100644 --- a/modules.local/ppcp-api-client/tests/PHPUnit/TestCase.php +++ b/modules.local/ppcp-api-client/tests/PHPUnit/TestCase.php @@ -6,6 +6,8 @@ namespace Inpsyde\PayPalCommerce\ApiClient; use function Brain\Monkey\setUp; use function Brain\Monkey\tearDown; +use function Brain\Monkey\Functions\expect; +use Mockery; class TestCase extends \PHPUnit\Framework\TestCase { public function setUp(): void @@ -16,7 +18,7 @@ class TestCase extends \PHPUnit\Framework\TestCase public function tearDown(): void { tearDown(); - \Mockery::close(); + Mockery::close(); parent::tearDown(); }