woocommerce/woocommerce-paypal-payments
2
0
Fork 0
mirror of https://github.com/woocommerce/woocommerce-paypal-payments.git synced 2025-09-01 07:02:48 +08:00
Code Issues Projects Packages Wiki Activity Actions

♻️ Remove an unused param to avoid confusion

Browse source 
The DCC status is not defered from the Settings instance, but from the specific DCCGatewayConfiguration service.
This commit is contained in:
Philipp Stracker 2025-03-14 11:42:41 +01:00
parent 16b4e235f2
commit a39edd0225
No known key found for this signature in database
2 changed files with 2 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

5
modules/ppcp-axo/services.php
View file

@ -196,10 +196,7 @@ return array(
$compatibility_checker = $container->get( 'axo.helpers.compatibility-checker' ); $compatibility_checker = $container->get( 'axo.helpers.compatibility-checker' );
assert( $compatibility_checker instanceof CompatibilityChecker ); assert( $compatibility_checker instanceof CompatibilityChecker );
$settings = $container->get( 'wcgateway.settings' ); return $compatibility_checker->generate_settings_conflict_notice();
assert( $settings instanceof Settings );
return $compatibility_checker->generate_settings_conflict_notice( $settings );
}, },
'axo.checkout-config-notice' => static function ( ContainerInterface $container ) : string { 'axo.checkout-config-notice' => static function ( ContainerInterface $container ) : string {

3
modules/ppcp-axo/src/Helper/CompatibilityChecker.php
View file

@ -223,11 +223,10 @@ class CompatibilityChecker {
/** /**
* Generates a warning notice with instructions on conflicting plugin-internal settings. * Generates a warning notice with instructions on conflicting plugin-internal settings.
* *
* @param Settings $settings The plugin settings container, which is checked for conflicting values.
* @param bool $raw_message Whether to return raw message without HTML wrappers. * @param bool $raw_message Whether to return raw message without HTML wrappers.
* @return string * @return string
*/ */
public function generate_settings_conflict_notice( Settings $settings, bool $raw_message = false ) : string { public function generate_settings_conflict_notice( bool $raw_message = false ) : string {
if ( $this->dcc_configuration->is_enabled() ) { if ( $this->dcc_configuration->is_enabled() ) {
return ''; return '';
} }