Fix phpcs errors

This commit is contained in:
dinamiko 2021-03-10 12:55:35 +01:00
parent ed3a91f333
commit a291c0da1a
4 changed files with 34 additions and 11 deletions

View file

@ -204,7 +204,7 @@ class SmartButton implements SmartButtonInterface {
if ( $this->can_save_credit_card() ) {
$default_fields['card-vault'] = sprintf(
'<p class="form-row form-row-wide"><label for="vault"><input class="ppcp-credit-card-vault" type="checkbox" id="ppcp-credit-card-vault" name="vault">%1$s</label></p>',
esc_html( 'Save your Credit Card', 'woocommerce-paypal-payments' )
esc_html__( 'Save your Credit Card', 'woocommerce-paypal-payments' )
);
}
return $default_fields;
@ -560,6 +560,12 @@ class SmartButton implements SmartButtonInterface {
return is_user_logged_in();
}
/**
* Checks whether it can save credit cards.
*
* @return bool
* @throws \WooCommerce\PayPalCommerce\WcGateway\Exception\NotFoundException When nothing was found.
*/
private function can_save_credit_card() {
if ( ! $this->settings->has( 'client_id' ) || ! $this->settings->get( 'client_id' ) ) {
return false;
@ -903,6 +909,12 @@ class SmartButton implements SmartButtonInterface {
return true;
}
/**
* Checks if can save PayPal accounts.
*
* @return bool Whether it can save it or not.
* @throws \WooCommerce\PayPalCommerce\WcGateway\Exception\NotFoundException If a setting has not been found.
*/
private function save_paypal_account(): bool {
if ( ! $this->settings->has( 'save_paypal_account' ) || ! $this->settings->get( 'save_paypal_account' ) ) {
return false;
@ -943,8 +955,10 @@ class SmartButton implements SmartButtonInterface {
}
/**
* @return bool
* @throws \WooCommerce\PayPalCommerce\WcGateway\Exception\NotFoundException
* Checks if vault setting is either enabled for PayPal or credit card.
*
* @return bool Whether any of them is enabled or not.
* @throws \WooCommerce\PayPalCommerce\WcGateway\Exception\NotFoundException When a setting hasn't been found.
*/
protected function vault_settings_enabled(): bool {
if ( ! $this->settings->has( 'vault_enabled' ) && ! $this->settings->has( 'dcc_vault_enabled' )
@ -954,6 +968,12 @@ class SmartButton implements SmartButtonInterface {
return true;
}
/**
* Checks if vaulting for credit card is enabled.
*
* @return bool Whether if it is enabled or not.
* @throws \WooCommerce\PayPalCommerce\WcGateway\Exception\NotFoundException When a setting hasn't been found.
*/
protected function vault_card_setting_enabled(): bool {
if ( ! $this->settings->get( 'dcc_vault_enabled' ) && ! $this->settings->get( 'dcc_vault_enabled' ) ) {
return false;

View file

@ -61,16 +61,17 @@ class SubscriptionModule implements ModuleInterface {
}
/**
* @param $order
* @param ContainerInterface|null $container
* Handles a Subscription product renewal.
*
* @param \WC_Order $order WooCommerce order.
* @param ContainerInterface|null $container The container.
* @return void
*/
protected function renew( $order, ?ContainerInterface $container ) {
protected function renew( $order, $container ) {
if ( ! is_a( $order, \WC_Order::class ) ) {
return;
}
/** @var RenewalHandler $handler */
$handler = $container->get( 'subscription.renewal-handler' );
$handler->renew( $order );
}

View file

@ -482,7 +482,7 @@ return array(
'dcc_vault_enabled' => array(
'title' => __( 'Vaulting For Credit Cards', 'woocommerce-paypal-payments' ),
'desc_tip' => true,
'description' => __( '', 'woocommerce-paypal-payments' ),
'description' => __( 'Enable Payment Tokens for WooCommerce Subscription renewals', 'woocommerce-paypal-payments' ),
'label' => __( 'Enable Vaulting For Credit Cards', 'woocommerce-paypal-payments' ),
'type' => 'checkbox',
'default' => false,
@ -653,7 +653,7 @@ return array(
'type' => 'checkbox',
'desc_tip' => true,
'label' => __( 'Enable Vaulting for PayPal Accounts', 'woocommerce-paypal-payments' ),
'description' => __( '', 'woocommerce-paypal-payments' ),
'description' => __( 'Enable Payment Tokens for WooCommerce Subscription renewals', 'woocommerce-paypal-payments' ),
'default' => false,
'screens' => array(
State::STATE_ONBOARDED,

View file

@ -87,8 +87,10 @@ trait ProcessPaymentTrait {
}
/**
* @return bool
* @throws \WooCommerce\PayPalCommerce\WcGateway\Exception\NotFoundException
* Checks if vault setting is either enabled for PayPal or Credit Card.
*
* @return bool Whether vault settings are enabled or not.
* @throws \WooCommerce\PayPalCommerce\WcGateway\Exception\NotFoundException When a setting hasn't been found.
*/
protected function vault_settings_enabled(): bool {
if ( ! $this->config->has( 'vault_enabled' ) && ! $this->config->has( 'dcc_vault_enabled' )