woocommerce/woocommerce-paypal-payments
2
0
Fork 0
mirror of https://github.com/woocommerce/woocommerce-paypal-payments.git synced 2025-09-07 19:54:15 +08:00
Code Issues Projects Packages Wiki Activity Actions

Merge pull request #3143 from woocommerce/PCP-4245-undefined-array-key-block-editor-in-styling-settings-map-helper-php-line-179

Browse source 
Fix the warning message related to the 'block-editor' location (4245)
This commit is contained in:
Emili Castells 2025-02-24 13:40:54 +01:00 • committed by GitHub
commit 9f78224d75
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
modules/ppcp-compat/src/Settings/StylingSettingsMapHelper.php
View file

@ -224,9 +224,10 @@ class StylingSettingsMapHelper {
protected function mapped_disabled_funding_value( array $styling_models ): ?array { protected function mapped_disabled_funding_value( array $styling_models ): ?array {
$disabled_funding = array(); $disabled_funding = array();
$locations_to_context_map = $this->current_context_to_new_button_location_map(); $locations_to_context_map = $this->current_context_to_new_button_location_map();
$current_context = $locations_to_context_map[ $this->context() ] ?? '';
foreach ( $styling_models as $model ) { foreach ( $styling_models as $model ) {
if ( $model->location !== $locations_to_context_map[ $this->context() ] || in_array( 'venmo', $model->methods, true ) ) { if ( $model->location !== $current_context || in_array( 'venmo', $model->methods, true ) ) {
continue; continue;
} }
@ -252,10 +253,11 @@ class StylingSettingsMapHelper {
} }
$locations_to_context_map = $this->current_context_to_new_button_location_map(); $locations_to_context_map = $this->current_context_to_new_button_location_map();
$current_context = $locations_to_context_map[ $this->context() ] ?? '';
foreach ( $styling_models as $model ) { foreach ( $styling_models as $model ) {
if ( ! $model->enabled if ( ! $model->enabled
|| $model->location !== $locations_to_context_map[ $this->context() ] || $model->location !== $current_context
|| ! in_array( $button_name, $model->methods, true ) || ! in_array( $button_name, $model->methods, true )
) { ) {
continue; continue;