From 9dc1bf7d7b939a7f65bdf102495f049907689e4f Mon Sep 17 00:00:00 2001
From: Philipp Stracker <p.stracker@syde.com>
Date: Tue, 25 Mar 2025 16:43:33 +0100
Subject: [PATCH] =?UTF-8?q?=E2=99=BB=EF=B8=8F=20Remove=20empty=20payment?=
 =?UTF-8?q?=20methods=20in=20JS=20hook?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../resources/js/data/payment/hooks.js        | 34 ++++++++-----------
 1 file changed, 14 insertions(+), 20 deletions(-)

diff --git a/modules/ppcp-settings/resources/js/data/payment/hooks.js b/modules/ppcp-settings/resources/js/data/payment/hooks.js
index 6060041f4..9e9b23d5e 100644
--- a/modules/ppcp-settings/resources/js/data/payment/hooks.js
+++ b/modules/ppcp-settings/resources/js/data/payment/hooks.js
@@ -83,34 +83,22 @@ export const usePaymentMethods = () => {
 	const [ pui ] = usePersistent( 'ppcp-pay-upon-invoice-gateway' );
 	const [ oxxo ] = usePersistent( 'ppcp-oxxo-gateway' );
 
-	const payPalCheckout = [ paypal, venmo, payLater, creditCard ];
-	const onlineCardPayments = [
-		advancedCreditCard,
-		fastlane,
-		applePay,
-		googlePay,
-	];
-	const alternative = [
-		bancontact,
-		blik,
-		eps,
-		ideal,
-		mybank,
-		p24,
-		trustly,
-		multibanco,
-		pui,
-		oxxo,
-	];
-	const paymentMethods = [
+	const removeEmpty = ( list ) =>
+		list.filter( ( item ) => item && item.id?.length );
+
+	const payPalCheckout = removeEmpty( [
 		paypal,
 		venmo,
 		payLater,
 		creditCard,
+	] );
+	const onlineCardPayments = removeEmpty( [
 		advancedCreditCard,
 		fastlane,
 		applePay,
 		googlePay,
+	] );
+	const alternative = removeEmpty( [
 		bancontact,
 		blik,
 		eps,
@@ -121,6 +109,12 @@ export const usePaymentMethods = () => {
 		multibanco,
 		pui,
 		oxxo,
+	] );
+
+	const paymentMethods = [
+		...payPalCheckout,
+		...onlineCardPayments,
+		...alternative,
 	];
 
 	return {