From 9c1803e8ea4a39b4219e7cfe04bee9f5b101078d Mon Sep 17 00:00:00 2001
From: Philipp Stracker <p.stracker@syde.com>
Date: Mon, 27 Jan 2025 15:30:21 +0100
Subject: [PATCH] =?UTF-8?q?=E2=9A=A1=EF=B8=8F=20Resolve=20unnecessary=20re?=
 =?UTF-8?q?-render=20of=20header?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../Components/Screens/Settings/Components/Navigation.js | 9 +++------
 .../ppcp-settings/resources/js/hooks/useSaveSettings.js  | 6 ++++--
 2 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/modules/ppcp-settings/resources/js/Components/Screens/Settings/Components/Navigation.js b/modules/ppcp-settings/resources/js/Components/Screens/Settings/Components/Navigation.js
index 9767730b7..e43644f7b 100644
--- a/modules/ppcp-settings/resources/js/Components/Screens/Settings/Components/Navigation.js
+++ b/modules/ppcp-settings/resources/js/Components/Screens/Settings/Components/Navigation.js
@@ -2,7 +2,6 @@ import { Button } from '@wordpress/components';
 import { __ } from '@wordpress/i18n';
 
 import TopNavigation from '../../../ReusableComponents/TopNavigation';
-import BusyStateWrapper from '../../../ReusableComponents/BusyStateWrapper';
 import { useSaveSettings } from '../../../../hooks/useSaveSettings';
 
 const SettingsNavigation = () => {
@@ -12,11 +11,9 @@ const SettingsNavigation = () => {
 
 	return (
 		<TopNavigation title={ title } exitOnTitleClick={ true }>
-			<BusyStateWrapper>
-				<Button variant="primary" onClick={ persistAll }>
-					{ __( 'Save', 'woocommerce-paypal-payments' ) }
-				</Button>
-			</BusyStateWrapper>
+			<Button variant="primary" onClick={ persistAll }>
+				{ __( 'Save', 'woocommerce-paypal-payments' ) }
+			</Button>
 		</TopNavigation>
 	);
 };
diff --git a/modules/ppcp-settings/resources/js/hooks/useSaveSettings.js b/modules/ppcp-settings/resources/js/hooks/useSaveSettings.js
index bc5e95f20..f268d3214 100644
--- a/modules/ppcp-settings/resources/js/hooks/useSaveSettings.js
+++ b/modules/ppcp-settings/resources/js/hooks/useSaveSettings.js
@@ -1,3 +1,5 @@
+import { useCallback } from '@wordpress/element';
+
 import {
 	CommonHooks,
 	PaymentHooks,
@@ -12,7 +14,7 @@ export const useSaveSettings = () => {
 	const { persist: persistSettings } = SettingsHooks.useStore();
 	const { persist: persistStyling } = StylingHooks.useStore();
 
-	const persistAll = () => {
+	const persistAll = useCallback( () => {
 		withActivity(
 			'persist-methods',
 			'Save payment methods',
@@ -28,7 +30,7 @@ export const useSaveSettings = () => {
 			'Save styling details',
 			persistStyling
 		);
-	};
+	}, [ persistPayment, persistSettings, persistStyling, withActivity ] );
 
 	return { persistAll };
 };