woocommerce/woocommerce-paypal-payments
2
0
Fork 0
mirror of https://github.com/woocommerce/woocommerce-paypal-payments.git synced 2025-09-06 14:57:26 +08:00
Code Issues Projects Packages Wiki Activity Actions

✨ Replace isBusy with new activity-state manager

Browse source
This commit is contained in:
Philipp Stracker 2024-12-05 18:55:56 +01:00
parent 405c397331
commit 9786a18eb0
No known key found for this signature in database
5 changed files with 77 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

37
modules/ppcp-settings/resources/js/data/common/actions.js
View file

@ -59,14 +59,35 @@ export const setIsSaving = ( isSaving ) => ( {
} );
/**
* Transient. Changes the "manual connection is busy" flag.
* Transient (Activity): Marks the start of an async activity
* Think of it as "setIsBusy(true)"
*
* @param {boolean} isBusy
* @param {string} id Internal ID/key of the action, used to stop it again.
* @param {?string} description Optional, description for logging/debugging
* @return {?Action} The action.
*/
export const startActivity = ( id, description = null ) => {
if ( ! id || 'string' !== typeof id ) {
console.warn( 'Activity ID must be a non-empty string' );
return null;
}
return {
type: ACTION_TYPES.START_ACTIVITY,
payload: { id, description },
};
};
/**
* Transient (Activity): Marks the end of an async activity.
* Think of it as "setIsBusy(false)"
*
* @param {string} id Internal ID/key of the action, used to stop it again.
* @return {Action} The action.
*/
export const setIsBusy = ( isBusy ) => ( {
type: ACTION_TYPES.SET_TRANSIENT,
payload: { isBusy },
export const stopActivity = ( id ) => ( {
type: ACTION_TYPES.STOP_ACTIVITY,
payload: { id },
} );
/**
@ -130,10 +151,8 @@ export const persist = function* () {
* @return {Action} The action.
*/
export const connectToSandbox = function* () {
yield setIsBusy( true );
const result = yield { type: ACTION_TYPES.DO_SANDBOX_LOGIN };
yield setIsBusy( false );
return result;
};
@ -145,13 +164,11 @@ export const connectToSandbox = function* () {
* @return {Action} The action.
*/
export const connectToProduction = function* ( products = [] ) {
yield setIsBusy( true );
const result = yield {
type: ACTION_TYPES.DO_PRODUCTION_LOGIN,
products,
};
yield setIsBusy( false );
return result;
};
@ -165,7 +182,6 @@ export const connectViaIdAndSecret = function* () {
const { clientId, clientSecret, useSandbox } =
yield select( STORE_NAME ).persistentData();
yield setIsBusy( true );
const result = yield {
type: ACTION_TYPES.DO_MANUAL_CONNECTION,
@ -173,7 +189,6 @@ export const connectViaIdAndSecret = function* () {
clientSecret,
useSandbox,
};
yield setIsBusy( false );
return result;
};