woocommerce/woocommerce-paypal-payments
2
0
Fork 0
mirror of https://github.com/woocommerce/woocommerce-paypal-payments.git synced 2025-09-05 08:59:14 +08:00
Code Issues Projects Packages Wiki Activity Actions 7

🦺 Add check for config that causes infinite loop

Browse source
This commit is contained in:
Philipp Stracker 2024-06-07 21:12:34 +02:00
parent 33c6c06e85
commit 93f3e4e7ac
No known key found for this signature in database
2 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
modules/ppcp-applepay/resources/js/ApplepayButton.js
View file

@ -135,6 +135,10 @@ class ApplepayButton {
const { wrapper, ppcpButtonWrapper } = this.contextConfig(); const { wrapper, ppcpButtonWrapper } = this.contextConfig();
const wrapper_id = '#' + wrapper; const wrapper_id = '#' + wrapper;
if (wrapper_id === ppcpButtonWrapper) {
throw new Error(`[ApplePayButton] "wrapper" and "ppcpButtonWrapper" values must differ to avoid infinite loop. Current value: "${wrapper_id}"`);
}
const syncButtonVisibility = () => { const syncButtonVisibility = () => {
if (!this.isEligible) { if (!this.isEligible) {
return; return;

4
modules/ppcp-googlepay/resources/js/GooglepayButton.js
View file

@ -139,6 +139,10 @@ class GooglepayButton {
initEventHandlers() { initEventHandlers() {
const { wrapper, ppcpButtonWrapper } = this.contextConfig(); const { wrapper, ppcpButtonWrapper } = this.contextConfig();
if (wrapper === ppcpButtonWrapper) {
throw new Error(`[GooglePayButton] "wrapper" and "ppcpButtonWrapper" values must differ to avoid infinite loop. Current value: "${wrapper}"`);
}
const syncButtonVisibility = () => { const syncButtonVisibility = () => {
const $ppcpButtonWrapper = jQuery(ppcpButtonWrapper); const $ppcpButtonWrapper = jQuery(ppcpButtonWrapper);
setVisible(wrapper, $ppcpButtonWrapper.is(':visible')); setVisible(wrapper, $ppcpButtonWrapper.is(':visible'));