From 907567992145e371ecb43164186e45df27cffd5b Mon Sep 17 00:00:00 2001
From: Philipp Stracker
Date: Tue, 3 Dec 2024 17:54:09 +0100
Subject: [PATCH] =?UTF-8?q?=E2=99=BB=EF=B8=8F=20Rename=20Redux=20action=20?=
=?UTF-8?q?for=20consistent=20naming?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
---
modules/ppcp-settings/resources/js/data/common/actions.js | 7 ++++---
modules/ppcp-settings/resources/js/data/common/hooks.js | 8 ++++----
.../resources/js/hooks/useHandleConnections.js | 4 ++--
3 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/modules/ppcp-settings/resources/js/data/common/actions.js b/modules/ppcp-settings/resources/js/data/common/actions.js
index ad9a8f5b5..6b1a03b4e 100644
--- a/modules/ppcp-settings/resources/js/data/common/actions.js
+++ b/modules/ppcp-settings/resources/js/data/common/actions.js
@@ -122,7 +122,7 @@ export const persist = function* () {
*
* @return {Action} The action.
*/
-export const connectViaSandbox = function* () {
+export const connectToSandbox = function* () {
yield setIsBusy( true );
const result = yield { type: ACTION_TYPES.DO_SANDBOX_LOGIN };
@@ -134,14 +134,15 @@ export const connectViaSandbox = function* () {
/**
* Side effect. Initiates the production login ISU.
*
+ * @param {string[]} products Which products/features to display in the ISU popup.
* @return {Action} The action.
*/
-export const connectToProduction = function* () {
+export const connectToProduction = function* ( products = [] ) {
yield setIsBusy( true );
const result = yield {
type: ACTION_TYPES.DO_PRODUCTION_LOGIN,
- products: [ 'EXPRESS_CHECKOUT' ],
+ products,
};
yield setIsBusy( false );
diff --git a/modules/ppcp-settings/resources/js/data/common/hooks.js b/modules/ppcp-settings/resources/js/data/common/hooks.js
index fbe6a4842..3f9185102 100644
--- a/modules/ppcp-settings/resources/js/data/common/hooks.js
+++ b/modules/ppcp-settings/resources/js/data/common/hooks.js
@@ -31,7 +31,7 @@ const useHooks = () => {
setManualConnectionMode,
setClientId,
setClientSecret,
- connectViaSandbox,
+ connectToSandbox,
connectViaIdAndSecret,
} = useDispatch( STORE_NAME );
@@ -72,7 +72,7 @@ const useHooks = () => {
setClientSecret: ( value ) => {
return savePersistent( setClientSecret, value );
},
- connectViaSandbox,
+ connectToSandbox,
connectViaIdAndSecret,
wooSettings,
};
@@ -89,9 +89,9 @@ export const useBusyState = () => {
};
export const useSandbox = () => {
- const { isSandboxMode, setSandboxMode, connectViaSandbox } = useHooks();
+ const { isSandboxMode, setSandboxMode, connectToSandbox } = useHooks();
- return { isSandboxMode, setSandboxMode, connectViaSandbox };
+ return { isSandboxMode, setSandboxMode, connectToSandbox };
};
export const useManualConnection = () => {
diff --git a/modules/ppcp-settings/resources/js/hooks/useHandleConnections.js b/modules/ppcp-settings/resources/js/hooks/useHandleConnections.js
index b30d5213f..e9a2e30bc 100644
--- a/modules/ppcp-settings/resources/js/hooks/useHandleConnections.js
+++ b/modules/ppcp-settings/resources/js/hooks/useHandleConnections.js
@@ -26,12 +26,12 @@ const useCommonConnectionLogic = () => {
};
export const useSandboxConnection = () => {
- const { connectViaSandbox, isSandboxMode, setSandboxMode } =
+ const { connectToSandbox, isSandboxMode, setSandboxMode } =
CommonHooks.useSandbox();
const { handleServerError, createErrorNotice } = useCommonConnectionLogic();
const handleSandboxConnect = async () => {
- const res = await connectViaSandbox();
+ const res = await connectToSandbox();
if ( ! res.success || ! res.data ) {
handleServerError(