woocommerce/woocommerce-paypal-payments
2
0
Fork 0
mirror of https://github.com/woocommerce/woocommerce-paypal-payments.git synced 2025-09-04 08:47:23 +08:00
Code Issues Projects Packages Wiki Activity Actions 11

♻️ Make DCC check clearer in SmartButton class

Browse source 
Done during debugging to better understand the data flow, does not change/solve anything
This commit is contained in:
Philipp Stracker 2025-03-12 17:04:38 +01:00
parent 11f91eed62
commit 791a5d33da
No known key found for this signature in database
1 changed files with 17 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

30
modules/ppcp-button/src/Assets/SmartButton.php
View file

@ -1575,6 +1575,7 @@ document.querySelector("#payment").before(document.querySelector(".ppcp-messages
if ( $this->dcc_is_enabled() ) {
$components[] = 'hosted-fields';
}
/**
* Filter to add further components from the extensions.
*
@ -1597,24 +1598,27 @@ document.querySelector("#payment").before(document.querySelector(".ppcp-messages
*
* @return bool
*/
private function dcc_is_enabled(): bool {
if ( ! is_checkout() ) {
private function dcc_is_enabled() : bool {
// Card payments are only available on the checkout page, and for certain seller countries.
if ( ! is_checkout() || ! $this->dcc_applies->for_country_currency() ) {
return false;
}
if ( ! $this->dcc_applies->for_country_currency() ) {
return false;
}
$keys = array(
'client_id',
'client_secret',
'dcc_enabled',
);
foreach ( $keys as $key ) {
if ( ! $this->settings->has( $key ) || ! $this->settings->get( $key ) ) {
try {
// Bail, if the merchant is not fully onboarded yet.
if (
! $this->settings->get( 'client_id' )
|| ! $this->settings->get( 'client_secret' )
) {
return false;
}
// The actual condition that must be met.
return (bool) $this->settings->get( 'dcc_enabled' );
} catch ( NotFoundException $e ) {
// Bail, if the settings DB entries are missing.
return false;
}
return true;
}
/**