woocommerce/woocommerce-paypal-payments
2
0
Fork 0
mirror of https://github.com/woocommerce/woocommerce-paypal-payments.git synced 2025-09-05 08:59:14 +08:00
Code Issues Projects Packages Wiki Activity Actions 7

move item construction in wc order to itemfactory

Browse source
This commit is contained in:
David Remer 2020-04-14 08:22:35 +03:00
parent 19c53dd644
commit 70915eae3d
2 changed files with 26 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

24
modules.local/ppcp-api-client/src/Factory/ItemFactory.php
View file

@ -14,6 +14,30 @@ class ItemFactory
{
}
public function fromWcOrderLineItem(\WC_Order_Item_Product $item, \WC_Order $order, string $currency) : Item {
$product = $item->get_product();
/**
* @var \WC_Product $product
*/
$quantity = $item->get_quantity();
$price = (float) $order->get_item_subtotal($item, true);
$priceWithoutTax = (float) $order->get_item_subtotal($item, false);
$priceWithoutTaxRounded = round($priceWithoutTax, 2);
$tax = round($price - $priceWithoutTaxRounded, 2);
$tax = new Money($tax, $currency);
return new Item(
mb_substr($product->get_name(), 0, 127),
new Money($priceWithoutTaxRounded, $currency),
$quantity,
mb_substr($product->get_description(), 0, 127),
$tax,
$product->get_sku(),
($product->is_downloadable()) ? Item::DIGITAL_GOODS : Item::PHYSICAL_GOODS
);
}
public function fromPayPalRequest(\stdClass $data) : Item
{
if (! isset($data->name)) {

24
modules.local/ppcp-api-client/src/Factory/PurchaseUnitFactory.php
View file

@ -36,27 +36,7 @@ class PurchaseUnitFactory
$items = array_map(
function (\WC_Order_Item_Product $item) use ($currency, $order): Item {
$product = $item->get_product();
/**
* @var \WC_Product $product
*/
$quantity = $item->get_quantity();
$price = (float) $order->get_item_subtotal($item, true);
$priceWithoutTax = (float) $order->get_item_subtotal($item, false);
$priceWithoutTaxRounded = round($priceWithoutTax, 2);
$tax = round($price - $priceWithoutTaxRounded, 2);
$tax = new Money($tax, $currency);
return new Item(
mb_substr($product->get_name(), 0, 127),
new Money($priceWithoutTaxRounded, $currency),
$quantity,
mb_substr($product->get_description(), 0, 127),
$tax,
$product->get_sku(),
($product->is_downloadable()) ? Item::DIGITAL_GOODS : Item::PHYSICAL_GOODS
);
return $this->itemFactory->fromWcOrderLineItem($item, $order, $currency);
},
$order->get_items('line_item')
);
@ -82,7 +62,7 @@ class PurchaseUnitFactory
), $currency);
$discount = null;
if ((float) $order->get_total_discount()) {
if ((float) $order->get_total_discount(false)) {
$discount = new Money(
(float) $order->get_total_discount(false),
$currency