woocommerce/woocommerce-paypal-payments
2
0
Fork 0
mirror of https://github.com/woocommerce/woocommerce-paypal-payments.git synced 2025-09-01 07:02:48 +08:00
Code Issues Projects Packages Wiki Activity Actions

♻️ Improve the Redux hook

Browse source
This commit is contained in:
Philipp Stracker 2025-02-10 19:10:04 +01:00
parent 988d221a98
commit 6e7a6496e5
No known key found for this signature in database
1 changed files with 19 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

36
modules/ppcp-settings/resources/js/data/common/hooks.js
View file

@ -8,7 +8,7 @@
*/ */
import { useDispatch, useSelect } from '@wordpress/data'; import { useDispatch, useSelect } from '@wordpress/data';
import { useCallback, useEffect, useState } from '@wordpress/element'; import { useCallback, useEffect, useMemo, useState } from '@wordpress/element';
import { createHooksForStore } from '../utils'; import { createHooksForStore } from '../utils';
import { STORE_NAME } from './constants'; import { STORE_NAME } from './constants';
@ -36,10 +36,6 @@ const useHooks = () => {
const [ isManualConnectionMode, setManualConnectionMode ] = usePersistent( const [ isManualConnectionMode, setManualConnectionMode ] = usePersistent(
'useManualConnection' 'useManualConnection'
); );
const merchant = useSelect(
( select ) => select( STORE_NAME ).merchant(),
[]
);
// Read-only properties. // Read-only properties.
const wooSettings = useSelect( const wooSettings = useSelect(
@ -78,7 +74,6 @@ const useHooks = () => {
productionOnboardingUrl, productionOnboardingUrl,
authenticateWithCredentials, authenticateWithCredentials,
authenticateWithOAuth, authenticateWithOAuth,
merchant,
wooSettings, wooSettings,
features, features,
webhooks, webhooks,
@ -169,18 +164,25 @@ export const useMerchantInfo = () => {
// Read-only access to the sanitized merchant details. // Read-only access to the sanitized merchant details.
export const useMerchant = () => { export const useMerchant = () => {
const { merchant } = useHooks(); const merchant = useSelect(
( select ) => select( STORE_NAME ).merchant(),
[]
);
return { return useMemo(
isConnected: merchant.isConnected ?? false, () => ( {
isSandbox: merchant.isSandbox ?? true, isConnected: merchant.isConnected ?? false,
id: merchant.id ?? '', isSandbox: merchant.isSandbox ?? true,
email: merchant.email ?? '', id: merchant.id ?? '',
clientId: merchant.clientId ?? '', email: merchant.email ?? '',
clientSecret: merchant.clientSecret ?? '', clientId: merchant.clientId ?? '',
isBusinessSeller: 'business' === merchant.sellerType, clientSecret: merchant.clientSecret ?? '',
isCasualSeller: 'personal' === merchant.sellerType, isBusinessSeller: 'business' === merchant.sellerType,
}; isCasualSeller: 'personal' === merchant.sellerType,
} ),
// the merchant object is stable, so a new memo is only generated when a merchant prop changes.
[ merchant ]
);
}; };
export const useActiveModal = () => { export const useActiveModal = () => {