small refactor of /AuthorizedPaymentsProcessor

This commit is contained in:
David Remer 2020-04-29 09:20:03 +03:00
parent 80b129c92d
commit 6b8ed27283

View file

@ -87,24 +87,22 @@ class AuthorizedPaymentsProcessor
private function areAuthorizationToCapture(Authorization ...$authorizations): bool
{
$alreadyCapturedAuthorizations = $this->authorizationsWithCapturedStatus(...$authorizations);
return count($alreadyCapturedAuthorizations) !== count($authorizations);
return (bool) count($this->authorizationsToCapture(...$authorizations));
}
private function captureAuthorizations(Authorization ...$authorizations)
{
$uncapturedAuthorizations = $this->authorizationsWithCreatedStatus(...$authorizations);
$uncapturedAuthorizations = $this->authorizationsToCapture(...$authorizations);
foreach ($uncapturedAuthorizations as $authorization) {
$this->paymentsEndpoint->capture($authorization->id());
}
}
/**
* @param Authorization ...$authorizations
* @return Authorization[]
*/
private function authorizationsWithCreatedStatus(Authorization ...$authorizations): array
private function authorizationsToCapture(Authorization ...$authorizations): array
{
return array_filter(
$authorizations,
@ -113,17 +111,4 @@ class AuthorizedPaymentsProcessor
}
);
}
/**
* @return Authorization[]
*/
private function authorizationsWithCapturedStatus(Authorization ...$authorizations): array
{
return array_filter(
$authorizations,
static function (Authorization $authorization): bool {
return $authorization->status()->is(AuthorizationStatus::CAPTURED);
}
);
}
}