woocommerce/woocommerce-paypal-payments
2
0
Fork 0
mirror of https://github.com/woocommerce/woocommerce-paypal-payments.git synced 2025-09-01 07:02:48 +08:00
Code Issues Projects Packages Wiki Activity Actions

Refactor WooCommerce\PayPalCommerce\Onboarding\Exception\RuntimeException to \RuntimeException

Browse source 
Refactor to use add_query_arg in append_onboarding_token
This commit is contained in:
Pedro Silva 2023-07-12 14:57:57 +01:00
parent 96eae6c690
commit 35fbe42733
No known key found for this signature in database
GPG key ID: E2EE20C0669D24B3
5 changed files with 5 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

5
modules/ppcp-api-client/src/Repository/PartnerReferralsData.php
View file

@ -136,9 +136,8 @@ class PartnerReferralsData {
* @return array * @return array
*/ */
public function append_onboarding_token( array $data, string $token ): array { public function append_onboarding_token( array $data, string $token ): array {
$separator = strpos( $data['partner_config_override']['return_url'], '?' ) === false ? '?' : '&'; $data['partner_config_override']['return_url'] =
add_query_arg( 'ppcpToken', $token, $data['partner_config_override']['return_url'] );
$data['partner_config_override']['return_url'] .= $separator . 'ppcpToken=' . $token;
return $data; return $data;
} }
} }

18
modules/ppcp-onboarding/src/Exception/RuntimeException.php
View file

@ -1,18 +0,0 @@
<?php
/**
* The modules Runtime Exception.
*
* @package WooCommerce\PayPalCommerce\Onboarding\Exception
*/
declare(strict_types=1);
namespace WooCommerce\PayPalCommerce\Onboarding\Exception;
/**
* Class RuntimeException
*/
class RuntimeException extends \RuntimeException {
}

2
modules/ppcp-onboarding/src/Helper/OnboardingUrl.php
View file

@ -10,7 +10,7 @@ declare(strict_types=1);
namespace WooCommerce\PayPalCommerce\Onboarding\Helper; namespace WooCommerce\PayPalCommerce\Onboarding\Helper;
use WooCommerce\PayPalCommerce\ApiClient\Helper\Cache; use WooCommerce\PayPalCommerce\ApiClient\Helper\Cache;
use WooCommerce\PayPalCommerce\Onboarding\Exception\RuntimeException; use RuntimeException;
/** /**
* Class OnboardingUrl * Class OnboardingUrl

2
modules/ppcp-wc-gateway/src/Settings/SettingsListener.php
View file

@ -170,7 +170,7 @@ class SettingsListener {
/** /**
* Listens if the merchant ID should be updated. * Listens if the merchant ID should be updated.
*/ */
public function listen_for_merchant_id() { public function listen_for_merchant_id(): void {
if ( ! $this->is_valid_site_request() ) { if ( ! $this->is_valid_site_request() ) {
return; return;
} }

2
tests/PHPUnit/Onboarding/Helper/OnboardingUrlTest.php
View file

@ -5,7 +5,7 @@ namespace WooCommerce\PayPalCommerce\Onboarding\Helper;
use PHPUnit\Framework\TestCase; use PHPUnit\Framework\TestCase;
use WooCommerce\PayPalCommerce\ApiClient\Helper\Cache; use WooCommerce\PayPalCommerce\ApiClient\Helper\Cache;
use WooCommerce\PayPalCommerce\Onboarding\Exception\RuntimeException; use RuntimeException;
use function Brain\Monkey\Functions\when; use function Brain\Monkey\Functions\when;
class OnboardingUrlTest extends TestCase class OnboardingUrlTest extends TestCase