woocommerce/woocommerce-paypal-payments
2
0
Fork 0
mirror of https://github.com/woocommerce/woocommerce-paypal-payments.git synced 2025-09-05 08:59:14 +08:00
Code Issues Projects Packages Wiki Activity Actions 7

🩹 FIx potential problem with initialization order

Browse source
This commit is contained in:
Philipp Stracker 2024-08-28 15:54:41 +02:00
parent 72b9fdc251
commit 2fa5545af2
No known key found for this signature in database
1 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
modules/ppcp-button/resources/js/modules/Renderer/PaymentButton.js
View file

@ -732,12 +732,11 @@ export default class PaymentButton {
* Only relevant on the checkout page, i.e., when `this.isSeparateGateway` is `true` * Only relevant on the checkout page, i.e., when `this.isSeparateGateway` is `true`
*/ */
showPaymentGateway() { showPaymentGateway() {
if ( this.#gatewayInitialized ) { if (
return; this.#gatewayInitialized ||
} ! this.isSeparateGateway ||
this.#gatewayInitialized = true; ! this.isEligible
) {
if ( ! this.isSeparateGateway || ! this.isEligible ) {
return; return;
} }
@ -753,6 +752,7 @@ export default class PaymentButton {
.forEach( ( el ) => el.remove() ); .forEach( ( el ) => el.remove() );
this.log( 'Show gateway' ); this.log( 'Show gateway' );
this.#gatewayInitialized = true;
// This code runs only once, during button initialization, and fixes the initial visibility. // This code runs only once, during button initialization, and fixes the initial visibility.
this.isVisible = this.isCurrentGateway; this.isVisible = this.isCurrentGateway;