From 27f4ab442fb62cfe41e8fe148f87d1efdb08e9bd Mon Sep 17 00:00:00 2001 From: Philipp Stracker Date: Mon, 3 Mar 2025 15:27:53 +0100 Subject: [PATCH] =?UTF-8?q?=E2=99=BB=EF=B8=8F=20Move=20PayPal=20product=20?= =?UTF-8?q?names=20to=20config=20file?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Because constants are better than magic strings --- .../resources/js/data/onboarding/configuration.js | 6 ++++++ .../resources/js/data/onboarding/selectors.js | 11 ++++++----- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/modules/ppcp-settings/resources/js/data/onboarding/configuration.js b/modules/ppcp-settings/resources/js/data/onboarding/configuration.js index 4b31689b5..280fee3af 100644 --- a/modules/ppcp-settings/resources/js/data/onboarding/configuration.js +++ b/modules/ppcp-settings/resources/js/data/onboarding/configuration.js @@ -24,3 +24,9 @@ export const PRODUCT_TYPES = { PHYSICAL: 'physical', SUBSCRIPTIONS: 'subscriptions', }; + +export const PAYPAL_PRODUCTS = { + ACDC: 'PPCP', + BCDC: 'EXPRESS_CHECKOUT', + VAULTING: 'ADVANCED_VAULTING', +}; diff --git a/modules/ppcp-settings/resources/js/data/onboarding/selectors.js b/modules/ppcp-settings/resources/js/data/onboarding/selectors.js index d98e2a169..2e0bfed51 100644 --- a/modules/ppcp-settings/resources/js/data/onboarding/selectors.js +++ b/modules/ppcp-settings/resources/js/data/onboarding/selectors.js @@ -6,7 +6,8 @@ * * @file */ -import { PRODUCT_TYPES } from './configuration'; + +import { PAYPAL_PRODUCTS, PRODUCT_TYPES } from './configuration'; const EMPTY_OBJ = Object.freeze( {} ); @@ -63,13 +64,13 @@ export const determineProductsAndCaps = ( state ) => { * Branch 1: Credit Card Payments not available. * The store uses the Express-checkout product. */ - apiModules.push( 'EXPRESS_CHECKOUT' ); + apiModules.push( PAYPAL_PRODUCTS.BCDC ); } else if ( isCasualSeller ) { /** * Branch 2: Merchant has no business. * The store uses the Express-checkout product. */ - apiModules.push( 'EXPRESS_CHECKOUT' ); + apiModules.push( PAYPAL_PRODUCTS.BCDC ); } else { /** * Branch 3: Merchant is business, and can use CC payments. @@ -77,7 +78,7 @@ export const determineProductsAndCaps = ( state ) => { * * This is the only branch that can use subscriptions. */ - apiModules.push( 'PPCP' ); + apiModules.push( PAYPAL_PRODUCTS.ACDC ); if ( products?.includes( PRODUCT_TYPES.SUBSCRIPTIONS ) ) { options.useSubscriptions = true; @@ -89,7 +90,7 @@ export const determineProductsAndCaps = ( state ) => { } if ( canUseVaulting ) { - apiModules.push( 'ADVANCED_VAULTING' ); + apiModules.push( PAYPAL_PRODUCTS.VAULTING ); } return { products: apiModules, options };